moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 17:06:53 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-14905 Added more unit tests, plus stubs for all methods to be tested. Also fixed a bug in moodle_database:get_recordset_list(), which was using " AND " between values instead of " OR "

Browse source
This commit is contained in:
nicolasconnault 2008-06-18 14:53:01 +00:00
parent a4736e2808
commit 0088bd3167
2 changed files with 265 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

5
lib/dml/moodle_database.php
View file

@ -513,8 +513,7 @@ abstract class moodle_database {
* Get a number of records a moodle_recordset.
*
* Only records where $field takes one of the values $values are returned.
* $values should be a comma-separated list of values, for example "4,5,6,10"
* or "'foo','bar','baz'".
* $values must be an array of values.
*
* Other arguments and the return type as for @see function get_recordset.
*
@ -541,7 +540,7 @@ abstract class moodle_database {
$params[] = $value;
}
}
$select = implode(" AND ", $select);
$select = implode(" OR ", $select);
return $this->get_recordset_select($table, $select, $params, $sort, $fields, $limitfrom, $limitnum);
}