MDL-71242 core_course: Update test_course_get_recent_courses() unit test

Adds additional assertions in test_course_get_recent_courses() test to
ensure that the sort funcionality works as expected.
This commit is contained in:
Mihail Geshoski 2021-05-13 14:10:19 +08:00 committed by Eloy Lafuente (stronk7)
parent 68c90578e7
commit 069cc7164c

View file

@ -5453,7 +5453,16 @@ class core_course_courselib_testcase extends advanced_testcase {
// Every course accessed, order by shortname DESC. The last create course ($course[2]) should have the greater shortname.
$result = course_get_recent_courses($student->id, 0, 0, 'shortname DESC');
$this->assertCount(3, $result);
$this->assertEquals($courses[2]->id, array_shift($result)->id);
$this->assertEquals($courses[2]->id, array_values($result)[0]->id);
$this->assertEquals($courses[1]->id, array_values($result)[1]->id);
$this->assertEquals($courses[0]->id, array_values($result)[2]->id);
// Every course accessed, order by shortname ASC.
$result = course_get_recent_courses($student->id, 0, 0, 'shortname ASC');
$this->assertCount(3, $result);
$this->assertEquals($courses[0]->id, array_values($result)[0]->id);
$this->assertEquals($courses[1]->id, array_values($result)[1]->id);
$this->assertEquals($courses[2]->id, array_values($result)[2]->id);
$guestcourse = $generator->create_course(
(object)array('shortname' => 'guestcourse',