moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-08 18:36:42 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-63547 core_message: updated api::can_delete_message

Browse source
This commit is contained in:
Mark Nelson 2018-10-14 19:48:13 +08:00
parent 14de10c463
commit 08cb8a34f9
3 changed files with 51 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

25
message/tests/api_test.php
View file

@ -2226,6 +2226,31 @@ class core_message_api_testcase extends core_message_messagelib_testcase {
$this->assertTrue(\core_message\api::does_contact_request_exist($user2->id, $user1->id));
}
/**
* Test the user in conversation check.
*/
public function test_is_user_in_conversation() {
$user1 = self::getDataGenerator()->create_user();
$user2 = self::getDataGenerator()->create_user();
$conversationid = \core_message\api::create_conversation_between_users([$user1->id, $user2->id]);
$this->assertTrue(\core_message\api::is_user_in_conversation($user1->id, $conversationid));
}
/**
* Test the user in conversation check when they are not.
*/
public function test_is_user_in_conversation_when_not() {
$user1 = self::getDataGenerator()->create_user();
$user2 = self::getDataGenerator()->create_user();
$user3 = self::getDataGenerator()->create_user();
$conversationid = \core_message\api::create_conversation_between_users([$user1->id, $user2->id]);
$this->assertFalse(\core_message\api::is_user_in_conversation($user3->id, $conversationid));
}
/**
* Comparison function for sorting contacts.
*

2
message/tests/externallib_test.php
View file

@ -1648,7 +1648,7 @@ class core_message_externallib_testcase extends externallib_advanced_testcase {
$result = core_message_external::delete_message(-1, $user1->id);
$this->fail('Exception expected due invalid messageid.');
} catch (dml_missing_record_exception $e) {
$this->assertEquals('invalidrecordunknown', $e->errorcode);
$this->assertEquals('invalidrecord', $e->errorcode);
}
// Invalid user.