moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-07 01:46:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-49998 unit tests: files left open are our fault.

Browse source 
Get rid of the gc_collect_cycles() that only was
hiding incorrectly left open files. This must be fixed
in code when possible. And pdf libs allow us to do so.

Note that a lot of gc_collect_cycles() were added
in MDL-47675, I'd recommend to take a look to all them,
being replaced by fixes in code when possible.
This commit is contained in:
Eloy Lafuente (stronk7) 2015-04-27 00:45:32 +02:00
parent 84ea226616
commit 095ecde727
1 changed files with 0 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

7
mod/assign/feedback/editpdf/tests/editpdf_test.php
View file

@ -52,13 +52,6 @@ class assignfeedback_editpdf_testcase extends mod_assign_base_testcase {
parent::setUp(); parent::setUp();
} }
/**
* Tidy up open files that may be left open.
*/
protected function tearDown() {
gc_collect_cycles();
}
protected function create_assign_and_submit_pdf() { protected function create_assign_and_submit_pdf() {
global $CFG; global $CFG;
$assign = $this->create_instance(array('assignsubmission_onlinetext_enabled' => 1, $assign = $this->create_instance(array('assignsubmission_onlinetext_enabled' => 1,