moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-11 03:46:42 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-39883 events: Trigger a module created event when duplicating a module

Browse source
This commit is contained in:
Ankit Agarwal 2014-06-18 15:40:31 +08:00
parent 7d947ad66c
commit 0978aab839
3 changed files with 31 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
course/lib.php
View file

@ -3497,6 +3497,10 @@ function mod_duplicate_activity($course, $cm, $sr = null) {
$section = $DB->get_record('course_sections', array('id' => $cm->section, 'course' => $cm->course)); $section = $DB->get_record('course_sections', array('id' => $cm->section, 'course' => $cm->course));
moveto_module($newcm, $section, $cm); moveto_module($newcm, $section, $cm);
moveto_module($cm, $section, $newcm); moveto_module($cm, $section, $newcm);
// Trigger course module created event. We can trigger the event only if we know the newcmid.
$event = \core\event\course_module_created::create_from_cm($newcm);
$event->trigger();
} }
rebuild_course_cache($cm->course); rebuild_course_cache($cm->course);

4
course/modduplicate.php
View file

@ -120,6 +120,10 @@ if ($newcmid) {
$newcm = get_coursemodule_from_id('', $newcmid, $course->id, true, MUST_EXIST); $newcm = get_coursemodule_from_id('', $newcmid, $course->id, true, MUST_EXIST);
moveto_module($newcm, $section, $cm); moveto_module($newcm, $section, $cm);
moveto_module($cm, $section, $newcm); moveto_module($cm, $section, $newcm);
// Trigger course module created event. We can trigger the event only if we know the newcmid.
$event = \core\event\course_module_created::create_from_cm($newcm);
$event->trigger();
} }
$rc->destroy(); $rc->destroy();

26
course/tests/courselib_test.php
View file

@ -1950,7 +1950,7 @@ class core_course_courselib_testcase extends advanced_testcase {
* Tests for event related to course module creation. * Tests for event related to course module creation.
*/ */
public function test_course_module_created_event() { public function test_course_module_created_event() {
global $USER, $DB; global $USER, $DB, $CFG;
$this->resetAfterTest(); $this->resetAfterTest();
// Create an assign module. // Create an assign module.
@ -1958,9 +1958,8 @@ class core_course_courselib_testcase extends advanced_testcase {
$modinfo = $this->create_specific_module_test('assign'); $modinfo = $this->create_specific_module_test('assign');
$events = $sink->get_events(); $events = $sink->get_events();
$event = array_pop($events); $event = array_pop($events);
$sink->close();
$cm = $DB->get_record('course_modules', array('id' => $modinfo->coursemodule), '*', MUST_EXIST); $cm = get_coursemodule_from_id('assign', $modinfo->coursemodule, 0, false, MUST_EXIST);
$mod = $DB->get_record('assign', array('id' => $modinfo->instance), '*', MUST_EXIST); $mod = $DB->get_record('assign', array('id' => $modinfo->instance), '*', MUST_EXIST);
// Validate event data. // Validate event data.
@ -1988,6 +1987,27 @@ class core_course_courselib_testcase extends advanced_testcase {
$this->assertEventLegacyLogData($arr, $event); $this->assertEventLegacyLogData($arr, $event);
$this->assertEventContextNotUsed($event); $this->assertEventContextNotUsed($event);
// Let us see if duplicating an activity results in a nice course module created event.
$sink->clear();
$course = get_course($mod->course);
// Discard error logs.
$oldlog = ini_get('error_log');
ini_set('error_log', "$CFG->dataroot/testlog.log");
$newcmhtml = mod_duplicate_activity($course, $cm);
ini_set('error_log', $oldlog);
$events = $sink->get_events();
$event = array_pop($events);
$sink->close();
// Validate event data.
$this->assertInstanceOf('\core\event\course_module_created', $event);
$this->assertEquals($newcmhtml->cmid, $event->objectid);
$this->assertEquals($USER->id, $event->userid);
$this->assertEquals($course->id, $event->courseid);
$url = new moodle_url('/mod/assign/view.php', array('id' => $newcmhtml->cmid));
$this->assertEquals($url, $event->get_url());
} }
/** /**