MDL-74941 qtype_calculated: Copy dataset from previous question version

This commit is contained in:
Steve Bader 2022-09-07 15:48:30 -04:00 committed by Luca Bösch
parent 27093b1893
commit 0e18ad33a1

View file

@ -640,7 +640,7 @@ class qtype_calculated extends question_type {
if (isset($form->synchronize) && $form->synchronize == 2) { if (isset($form->synchronize) && $form->synchronize == 2) {
$this->addnamecategory($question); $this->addnamecategory($question);
} }
} else if (!empty($form->makecopy)) { } else {
$questionfromid = $form->id; $questionfromid = $form->id;
$question = parent::save_question($question, $form); $question = parent::save_question($question, $form);
// Prepare the datasets. // Prepare the datasets.
@ -650,16 +650,6 @@ class qtype_calculated extends question_type {
if (isset($form->synchronize) && $form->synchronize == 2) { if (isset($form->synchronize) && $form->synchronize == 2) {
$this->addnamecategory($question); $this->addnamecategory($question);
} }
} else {
// Editing a question.
$question = parent::save_question($question, $form);
// Prepare the datasets.
$this->preparedatasets($form, $question->id);
$form->id = $question->id;
$this->save_dataset_definitions($form);
if (isset($form->synchronize) && $form->synchronize == 2) {
$this->addnamecategory($question);
}
} }
break; break;
case 'datasetdefinitions': case 'datasetdefinitions':