moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-04 16:36:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-75883 reportbuilder: Don't reload content when filter is deleted

Browse source 
- When filter is deleted in editing mode content does not need
to be reloaded
This commit is contained in:
David Matamoros 2022-10-04 15:48:21 +02:00
parent cc4fec275f
commit 0e449ae6ee
3 changed files with 3 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
reportbuilder/amd/build/local/editor/filters.min.js vendored
View file

File diff suppressed because one or more lines are too long

2
reportbuilder/amd/build/local/editor/filters.min.js.map
View file

File diff suppressed because one or more lines are too long

7
reportbuilder/amd/src/local/editor/filters.js
View file

@ -25,7 +25,6 @@
import $ from 'jquery'; import $ from 'jquery';
import CustomEvents from 'core/custom_interaction_events'; import CustomEvents from 'core/custom_interaction_events';
import {dispatchEvent} from 'core/event_dispatcher';
import 'core/inplace_editable'; import 'core/inplace_editable';
import Notification from 'core/notification'; import Notification from 'core/notification';
import Pending from 'core/pending'; import Pending from 'core/pending';
@ -34,7 +33,6 @@ import SortableList from 'core/sortable_list';
import {get_string as getString} from 'core/str'; import {get_string as getString} from 'core/str';
import Templates from 'core/templates'; import Templates from 'core/templates';
import {add as addToast} from 'core/toast'; import {add as addToast} from 'core/toast';
import * as reportEvents from 'core_reportbuilder/local/events';
import * as reportSelectors from 'core_reportbuilder/local/selectors'; import * as reportSelectors from 'core_reportbuilder/local/selectors';
import {addFilter, deleteFilter, reorderFilter} from 'core_reportbuilder/local/repository/filters'; import {addFilter, deleteFilter, reorderFilter} from 'core_reportbuilder/local/repository/filters';
@ -139,10 +137,7 @@ export const init = initialized => {
return deleteFilter(reportElement.dataset.reportId, filterContainer.dataset.filterId) return deleteFilter(reportElement.dataset.reportId, filterContainer.dataset.filterId)
.then(data => reloadSettingsFiltersRegion(reportElement, data)) .then(data => reloadSettingsFiltersRegion(reportElement, data))
.then(() => addToast(getString('filterdeleted', 'core_reportbuilder', filterName))) .then(() => addToast(getString('filterdeleted', 'core_reportbuilder', filterName)))
.then(() => { .then(() => pendingPromise.resolve())
dispatchEvent(reportEvents.tableReload, {}, reportElement);
return pendingPromise.resolve();
})
.catch(Notification.exception); .catch(Notification.exception);
}).catch(() => { }).catch(() => {
return; return;