moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 08:56:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

initialized arrays and objects, fixed a few bugs

Browse source
This commit is contained in:
michaelpenne 2005-02-09 22:29:29 +00:00
parent 437fa2a748
commit 0f4be3f608
1 changed files with 11 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

19
mod/lesson/report.php
View file

@ -119,6 +119,7 @@
$lowscore = 1000000000000; // silly, but should work $lowscore = 1000000000000; // silly, but should work
$hightime = 0; $hightime = 0;
$lowtime = 1000000000000; // :) $lowtime = 1000000000000; // :)
$table = new stdClass;
// set up the table object // set up the table object
$table->head = array(get_string('studentname', 'lesson', $course->student), get_string('attempts', 'lesson'), get_string('highscore', 'lesson')); $table->head = array(get_string('studentname', 'lesson', $course->student), get_string('attempts', 'lesson'), get_string('highscore', 'lesson'));
@ -217,13 +218,14 @@
// some stat calculations // some stat calculations
$avescore = format_float($avescore/$numofattempts, 2, ".", ","); $avescore = format_float($avescore/$numofattempts, 2, ".", ",");
$avetime = format_float($avetime/$numofattempts, 2, ".", ","); $avetime = format_float($avetime/$numofattempts, 0, ".", ",");
$avetime = format_time($avetime); $avetime = format_time($avetime);
$hightime = format_time($hightime); $hightime = format_time($hightime);
$lowtime = format_time($lowtime); $lowtime = format_time($lowtime);
// output the stats // output the stats
print_heading(get_string('lessonstats', 'lesson')); print_heading(get_string('lessonstats', 'lesson'));
$stattable = new stdClass;
$stattable->head = array(get_string('averagescore', 'lesson'), get_string('averagetime', 'lesson'), $stattable->head = array(get_string('averagescore', 'lesson'), get_string('averagetime', 'lesson'),
get_string('highscore', 'lesson'), get_string('lowscore', 'lesson'), get_string('highscore', 'lesson'), get_string('lowscore', 'lesson'),
get_string('hightime', 'lesson'), get_string('lowtime', 'lesson')); get_string('hightime', 'lesson'), get_string('lowtime', 'lesson'));
@ -268,11 +270,13 @@
// now gather the stats into an object // now gather the stats into an object
$firstpageid = $pageid; $firstpageid = $pageid;
$pagestats = array();
while ($pageid != 0) { // EOL while ($pageid != 0) { // EOL
$page = $lessonpages[$pageid]; $page = $lessonpages[$pageid];
if ($allanswers = get_records_select("lesson_attempts", "lessonid = $lesson->id AND pageid = $page->id", "timeseen")) { if ($allanswers = get_records_select("lesson_attempts", "lessonid = $lesson->id AND pageid = $page->id", "timeseen")) {
// get them ready for processing // get them ready for processing
$orderedanswers = array();
foreach ($allanswers as $singleanswer) { foreach ($allanswers as $singleanswer) {
// ordering them like this, will help to find the single attempt record that we want to keep. // ordering them like this, will help to find the single attempt record that we want to keep.
$orderedanswers[$singleanswer->userid][$singleanswer->retry][] = $singleanswer; $orderedanswers[$singleanswer->userid][$singleanswer->retry][] = $singleanswer;
@ -362,7 +366,7 @@
} else { } else {
// no one answered yet... // no one answered yet...
} }
unset($orderedanswers); //unset($orderedanswers); initialized above now
$pageid = $page->nextpageid; $pageid = $page->nextpageid;
} }
@ -376,9 +380,9 @@
// and end of cluster pages // and end of cluster pages
while ($pageid != 0) { // EOL while ($pageid != 0) { // EOL
$page = $lessonpages[$pageid]; $page = $lessonpages[$pageid];
unset($answerpage); $answerpage = new stdClass;
unset($data); $data ='';
unset($answerdata); $answerdata = new stdClass;
$answerpage->title = $page->title; $answerpage->title = $page->title;
$answerpage->contents = $page->contents; $answerpage->contents = $page->contents;
@ -425,7 +429,6 @@
} }
unset($answerdata);
if (empty($userid)) { if (empty($userid)) {
// there is no userid, so set these vars and display stats. // there is no userid, so set these vars and display stats.
$answerpage->grayout = 0; $answerpage->grayout = 0;
@ -760,7 +763,7 @@
} }
/// actually start printing something /// actually start printing something
$table = new stdClass;
$table->wrap = array(); $table->wrap = array();
$table->width = "60%"; $table->width = "60%";
@ -815,7 +818,7 @@
$table->data[] = array($fontstart.get_string("answer", "lesson").":".$fontend); $table->data[] = array($fontstart.get_string("answer", "lesson").":".$fontend);
// apply the font to each answer // apply the font to each answer
foreach ($page->answerdata->answers as $answer){ foreach ($page->answerdata->answers as $answer){
unset($modified); $modified = array();
foreach ($answer as $single) { foreach ($answer as $single) {
// need to apply a font to each one // need to apply a font to each one
$modified[] = $fontstart2.$single.$fontend2; $modified[] = $fontstart2.$single.$fontend2;