NAVIGATION MDL-25468 remove optional_param from navigationlib.php, use override_active_url to help find the correct node

This commit is contained in:
Dongsheng Cai 2011-02-07 16:25:58 +08:00
parent eef3578af0
commit 100e0d4989
3 changed files with 4 additions and 19 deletions

View file

@ -3398,26 +3398,10 @@ class settings_navigation extends navigation_node {
if (portfolio_instances(true, false)) {
$portfolio = $usersetting->add(get_string('portfolios', 'portfolio'), null, self::TYPE_SETTING);
$config = optional_param('config', 0, PARAM_INT);
$hide = optional_param('hide', 0, PARAM_INT);
$url = new moodle_url('/user/portfolio.php', array('courseid'=>$course->id));
if ($hide !== 0) {
$url->param('hide', $hide);
}
if ($config !== 0) {
$url->param('config', $config);
}
$portfolio->add(get_string('configure', 'portfolio'), $url, self::TYPE_SETTING);
$page = optional_param('page', 0, PARAM_INT);
$perpage = optional_param('perpage', 10, PARAM_INT);
$url = new moodle_url('/user/portfoliologs.php', array('courseid'=>$course->id));
if ($page !== 0) {
$url->param('page', $page);
}
if ($perpage !== 0) {
$url->param('perpage', $perpage);
}
$portfolio->add(get_string('logs', 'portfolio'), $url, self::TYPE_SETTING);
}
}