moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 00:46:50 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-11580 support for hidden state modification in gradebook from activities (quiz now only) - part 1

Browse source 
the hiding/unhiding should be IMO locked in gradebook UI when activity overrides it
This commit is contained in:
skodak 2007-10-04 22:57:14 +00:00
parent 452b14b131
commit 1223d24a73
2 changed files with 26 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/gradelib.php
View file

@ -47,7 +47,7 @@ require_once($CFG->libdir . '/grade/grade_outcome.php');
* or key means do not change existing. * or key means do not change existing.
* *
* Only following grade item properties can be changed 'itemname', 'idnumber', 'gradetype', 'grademax', * Only following grade item properties can be changed 'itemname', 'idnumber', 'gradetype', 'grademax',
* 'grademin', 'scaleid', 'multfactor', 'plusfactor', 'deleted'. * 'grademin', 'scaleid', 'multfactor', 'plusfactor', 'deleted' and 'hidden'.
* *
* Manual, course or category items can not be updated by this function. * Manual, course or category items can not be updated by this function.
@ -64,7 +64,7 @@ function grade_update($source, $courseid, $itemtype, $itemmodule, $iteminstance,
global $USER; global $USER;
// only following grade_item properties can be changed in this function // only following grade_item properties can be changed in this function
$allowed = array('itemname', 'idnumber', 'gradetype', 'grademax', 'grademin', 'scaleid', 'multfactor', 'plusfactor', 'deleted'); $allowed = array('itemname', 'idnumber', 'gradetype', 'grademax', 'grademin', 'scaleid', 'multfactor', 'plusfactor', 'deleted', 'hidden');
// grade item identification // grade item identification
$params = compact('courseid', 'itemtype', 'itemmodule', 'iteminstance', 'itemnumber'); $params = compact('courseid', 'itemtype', 'itemmodule', 'iteminstance', 'itemnumber');

24
mod/quiz/lib.php
View file

@ -345,6 +345,30 @@ function quiz_grade_item_update($quiz) {
$params['gradetype'] = GRADE_TYPE_NONE; $params['gradetype'] = GRADE_TYPE_NONE;
} }
/* description by TJ:
1/ If the quiz is set to not show scores while the quiz is still open, and is set to show scores after
the quiz is closed, then create the grade_item with a show-after date that is the quiz close date.
2/ If the quiz is set to not show scores at either of those times, create the grade_item as hidden.
3/ If the quiz is set to show scores, create the grade_item visible.
*/
if (!($quiz->review & QUIZ_REVIEW_SCORES & QUIZ_REVIEW_CLOSED)
and !($quiz->review & QUIZ_REVIEW_SCORES & QUIZ_REVIEW_OPEN)) {
$params['hidden'] = 1;
} else if ( ($quiz->review & QUIZ_REVIEW_SCORES & QUIZ_REVIEW_CLOSED)
and !($quiz->review & QUIZ_REVIEW_SCORES & QUIZ_REVIEW_OPEN)) {
if ($quiz->timeclose) {
$params['hidden'] = $quiz->timeclose;
} else {
$params['hidden'] = 1;
}
} else {
// a) both open and closed enabled
// b) open enabled, closed disabled - we can not "hide after", grades are kept visible even after closing
$params['hidden'] = 0;
}
return grade_update('mod/quiz', $quiz->course, 'mod', 'quiz', $quiz->id, 0, NULL, $params); return grade_update('mod/quiz', $quiz->course, 'mod', 'quiz', $quiz->id, 0, NULL, $params);
} }