moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-04 16:36:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-29262 backup: new setting to control the ttl of backup logs

Browse source 
Add one new backup setting, moving from the general CFG->loglifetime,
to be able to delete backup logged information often.
This commit is contained in:
Eloy Lafuente (stronk7) 2012-04-22 21:16:54 +02:00
parent ead4f180a0
commit 14e2704ad4
4 changed files with 36 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

29
admin/settings/courses.php
View file

@ -92,8 +92,29 @@ if ($hassiteconfig
// Add a category for backups // Add a category for backups
$ADMIN->add('courses', new admin_category('backups', new lang_string('backups','admin'))); $ADMIN->add('courses', new admin_category('backups', new lang_string('backups','admin')));
// Create a page for general backup defaults // Create a page for general backups configuration and defaults.
$temp = new admin_settingpage('backupgeneralsettings', new lang_string('generalbackdefaults', 'backup'), 'moodle/backup:backupcourse'); $temp = new admin_settingpage('backupgeneralsettings', new lang_string('generalbackdefaults', 'backup'), 'moodle/backup:backupcourse');
// General configuration section.
$temp->add(new admin_setting_configselect('backup/loglifetime', new lang_string('loglifetime', 'backup'), new lang_string('configloglifetime', 'backup'), 30, array(
1 => new lang_string('numdays', '', 1),
2 => new lang_string('numdays', '', 2),
3 => new lang_string('numdays', '', 3),
5 => new lang_string('numdays', '', 5),
7 => new lang_string('numdays', '', 7),
10 => new lang_string('numdays', '', 10),
14 => new lang_string('numdays', '', 14),
20 => new lang_string('numdays', '', 20),
30 => new lang_string('numdays', '', 30),
60 => new lang_string('numdays', '', 60),
90 => new lang_string('numdays', '', 90),
120 => new lang_string('numdays', '', 120),
180 => new lang_string('numdays', '', 180),
365 => new lang_string('numdays', '', 365)
)));
// General defaults section.
$temp->add(new admin_setting_heading('generalsettings', new lang_string('generalsettings', 'backup'), ''));
$temp->add(new admin_setting_configcheckbox_with_lock('backup/backup_general_users', new lang_string('generalusers','backup'), new lang_string('configgeneralusers','backup'), array('value'=>1, 'locked'=>0))); $temp->add(new admin_setting_configcheckbox_with_lock('backup/backup_general_users', new lang_string('generalusers','backup'), new lang_string('configgeneralusers','backup'), array('value'=>1, 'locked'=>0)));
$temp->add(new admin_setting_configcheckbox_with_lock('backup/backup_general_anonymize', new lang_string('generalanonymize','backup'), new lang_string('configgeneralanonymize','backup'), array('value'=>0, 'locked'=>0))); $temp->add(new admin_setting_configcheckbox_with_lock('backup/backup_general_anonymize', new lang_string('generalanonymize','backup'), new lang_string('configgeneralanonymize','backup'), array('value'=>0, 'locked'=>0)));
$temp->add(new admin_setting_configcheckbox_with_lock('backup/backup_general_role_assignments', new lang_string('generalroleassignments','backup'), new lang_string('configgeneralroleassignments','backup'), array('value'=>1, 'locked'=>0))); $temp->add(new admin_setting_configcheckbox_with_lock('backup/backup_general_role_assignments', new lang_string('generalroleassignments','backup'), new lang_string('configgeneralroleassignments','backup'), array('value'=>1, 'locked'=>0)));
@ -106,8 +127,10 @@ if ($hassiteconfig
$temp->add(new admin_setting_configcheckbox_with_lock('backup/backup_general_histories', new lang_string('generalhistories','backup'), new lang_string('configgeneralhistories','backup'), array('value'=>0, 'locked'=>0))); $temp->add(new admin_setting_configcheckbox_with_lock('backup/backup_general_histories', new lang_string('generalhistories','backup'), new lang_string('configgeneralhistories','backup'), array('value'=>0, 'locked'=>0)));
$ADMIN->add('backups', $temp); $ADMIN->add('backups', $temp);
/// "backups" settingpage // Create a page for automated backups configuration and defaults.
$temp = new admin_settingpage('automated', new lang_string('automatedsetup','backup'), 'moodle/backup:backupcourse'); $temp = new admin_settingpage('automated', new lang_string('automatedsetup','backup'), 'moodle/backup:backupcourse');
// Automated configuration section.
$temp->add(new admin_setting_configselect('backup/backup_auto_active', new lang_string('active'), new lang_string('autoactivedescription', 'backup'), 0, array( $temp->add(new admin_setting_configselect('backup/backup_auto_active', new lang_string('active'), new lang_string('autoactivedescription', 'backup'), 0, array(
0 => new lang_string('autoactivedisabled', 'backup'), 0 => new lang_string('autoactivedisabled', 'backup'),
1 => new lang_string('autoactiveenabled', 'backup'), 1 => new lang_string('autoactiveenabled', 'backup'),
@ -139,7 +162,7 @@ if ($hassiteconfig
500 => '500'); 500 => '500');
$temp->add(new admin_setting_configselect('backup/backup_auto_keep', new lang_string('keep'), new lang_string('backupkeephelp'), 1, $keepoptoins)); $temp->add(new admin_setting_configselect('backup/backup_auto_keep', new lang_string('keep'), new lang_string('backupkeephelp'), 1, $keepoptoins));
// Automated defaults section.
$temp->add(new admin_setting_heading('automatedsettings', new lang_string('automatedsettings','backup'), '')); $temp->add(new admin_setting_heading('automatedsettings', new lang_string('automatedsettings','backup'), ''));
$temp->add(new admin_setting_configcheckbox('backup/backup_auto_users', new lang_string('generalusers', 'backup'), new lang_string('configgeneralusers', 'backup'), 1)); $temp->add(new admin_setting_configcheckbox('backup/backup_auto_users', new lang_string('generalusers', 'backup'), new lang_string('configgeneralusers', 'backup'), 1));
$temp->add(new admin_setting_configcheckbox('backup/backup_auto_role_assignments', new lang_string('generalroleassignments','backup'), new lang_string('configgeneralroleassignments','backup'), 1)); $temp->add(new admin_setting_configcheckbox('backup/backup_auto_role_assignments', new lang_string('generalroleassignments','backup'), new lang_string('configgeneralroleassignments','backup'), 1));

3
lang/en/backup.php
View file

@ -88,6 +88,7 @@ $string['configgenerallogs'] = 'If enabled logs will be included in backups by d
$string['configgeneralroleassignments'] = 'If enabled by default roles assignments will also be backed up.'; $string['configgeneralroleassignments'] = 'If enabled by default roles assignments will also be backed up.';
$string['configgeneraluserscompletion'] = 'If enabled user completion information will be included in backups by default.'; $string['configgeneraluserscompletion'] = 'If enabled user completion information will be included in backups by default.';
$string['configgeneralusers'] = 'Sets the default for whether to include users in backups.'; $string['configgeneralusers'] = 'Sets the default for whether to include users in backups.';
$string['configloglifetime'] = 'This specifies the length of time you want to keep backup logs information. Logs that are older than this age are automatically deleted. It is recommended to keep this value small, because backup logged information can be huge.';
$string['confirmcancel'] = 'Cancel backup'; $string['confirmcancel'] = 'Cancel backup';
$string['confirmcancelquestion'] = 'Are you sure you wish to cancel? $string['confirmcancelquestion'] = 'Are you sure you wish to cancel?
Any information you have entered will be lost.'; Any information you have entered will be lost.';
@ -126,6 +127,7 @@ $string['generalhistories'] = 'Include histories';
$string['generalgradehistories'] = 'Include histories'; $string['generalgradehistories'] = 'Include histories';
$string['generallogs'] = 'Include logs'; $string['generallogs'] = 'Include logs';
$string['generalroleassignments'] = 'Include role assignments'; $string['generalroleassignments'] = 'Include role assignments';
$string['generalsettings'] = 'General backup settings';
$string['generaluserscompletion'] = 'Include user completion information'; $string['generaluserscompletion'] = 'Include user completion information';
$string['generalusers'] = 'Include users'; $string['generalusers'] = 'Include users';
$string['importfile'] = 'Import a backup file'; $string['importfile'] = 'Import a backup file';
@ -145,6 +147,7 @@ $string['includeactivities'] = 'Include:';
$string['includeditems'] = 'Included items:'; $string['includeditems'] = 'Included items:';
$string['includesection'] = 'Section {$a}'; $string['includesection'] = 'Section {$a}';
$string['includeuserinfo'] = 'User data'; $string['includeuserinfo'] = 'User data';
$string['loglifetime'] = 'Keep logs for';
$string['locked'] = 'Locked'; $string['locked'] = 'Locked';
$string['lockedbypermission'] = 'You don\'t have sufficient permissions to change this setting'; $string['lockedbypermission'] = 'You don\'t have sufficient permissions to change this setting';
$string['lockedbyconfig'] = 'This setting has been locked by the default backup settings'; $string['lockedbyconfig'] = 'This setting has been locked by the default backup settings';

11
lib/cronlib.php
View file

@ -113,17 +113,18 @@ function cron_run() {
} }
// Delete old backup_controllers and logs // Delete old backup_controllers and logs.
if (!empty($CFG->loglifetime)) { // value in days $loglifetime = get_config('backup', 'loglifetime');
$loglifetime = $timenow - ($CFG->loglifetime * 3600 * 24); if (!empty($loglifetime)) { // Value in days.
// Delete child records from backup_logs $loglifetime = $timenow - ($loglifetime * 3600 * 24);
// Delete child records from backup_logs.
$DB->execute("DELETE FROM {backup_logs} $DB->execute("DELETE FROM {backup_logs}
WHERE EXISTS ( WHERE EXISTS (
SELECT 'x' SELECT 'x'
FROM {backup_controllers} bc FROM {backup_controllers} bc
WHERE bc.backupid = {backup_logs}.backupid WHERE bc.backupid = {backup_logs}.backupid
AND bc.timecreated < ?)", array($loglifetime)); AND bc.timecreated < ?)", array($loglifetime));
// Delete records from backup_controllers // Delete records from backup_controllers.
$DB->execute("DELETE FROM {backup_controllers} $DB->execute("DELETE FROM {backup_controllers}
WHERE timecreated < ?", array($loglifetime)); WHERE timecreated < ?", array($loglifetime));
mtrace(" Deleted old backup records"); mtrace(" Deleted old backup records");

2
version.php
View file

@ -30,7 +30,7 @@
defined('MOODLE_INTERNAL') || die(); defined('MOODLE_INTERNAL') || die();
$version = 2012041900.00; // YYYYMMDD = weekly release date of this DEV branch $version = 2012041900.01; // YYYYMMDD = weekly release date of this DEV branch
// RR = release increments - 00 in DEV branches // RR = release increments - 00 in DEV branches
// .XX = incremental changes // .XX = incremental changes