moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-04 00:16:46 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-21652 html_table rendering refactored

Browse source 
* class html_component does not exist any more
* class html_table rendered via html_writer::table()
* html_table, html_table_row and html_table_cell have public $attributes property to set their CSS classes
* dropped rotateheaders feature, should be added again after more research of possible ways (<svg> is not nice IMHO)
* dropped possibility to define CSS classes for table heading, body and footer - can be easily done and better done using just table class and context
This commit is contained in:
David Mudrak 2010-03-20 22:15:54 +00:00
parent ad70376ce2
commit 16be897441
106 changed files with 565 additions and 677 deletions
Download patch file Download diff file Expand all files Collapse all files

4
blog/external_blogs.php
View file

@ -68,7 +68,7 @@ echo $OUTPUT->box_start('generalbox boxaligncenter');
if (!empty($blogs)) {
$table = new html_table();
$table->cellpadding = 4;
$table->add_class('generaltable boxaligncenter');
$table->attributes['class'] = 'generaltable boxaligncenter';
$table->head = array(get_string('name'), get_string('url'), get_string('timefetched', 'blog'), get_string('valid', 'blog'), get_string('actions'));
foreach ($blogs as $blog) {
@ -87,7 +87,7 @@ if (!empty($blogs)) {
$table->data[] = new html_table_row(array($blog->name, $blog->url, userdate($blog->timefetched), $validicon, $editicon . $deleteicon));
}
echo $OUTPUT->table($table);
echo html_writer::table($table);
}
$newexternalurl = new moodle_url('/blog/external_blog_edit.php');

14
blog/locallib.php
View file

@ -133,17 +133,17 @@ class blog_entry {
// Start printing of the blog
$table = new html_table();
$table->cellspacing = 0;
$table->add_classes('forumpost blog_entry blog'. ($unassociatedentry ? 'draft' : $template['publishstate']));
$table->attributes['class'] = 'forumpost blog_entry blog'. ($unassociatedentry ? 'draft' : $template['publishstate']);
$table->width = '100%';
$picturecell = new html_table_cell();
$picturecell->add_classes('picture left');
$picturecell->attributes['class'] = 'picture left';
$picturecell->text = $OUTPUT->user_picture($user);
$table->head[] = $picturecell;
$topiccell = new html_table_cell();
$topiccell->add_classes('topic starter');
$topiccell->attributes['class'] = 'topic starter';
$topiccell->text = $OUTPUT->container($template['title'], 'subject');
$topiccell->text .= $OUTPUT->container_start('author');
@ -169,11 +169,11 @@ class blog_entry {
$mainrow = new html_table_row();
$leftsidecell = new html_table_cell();
$leftsidecell->add_classes('left side');
$leftsidecell->attributes['class'] = 'left side';
$mainrow->cells[] = $leftsidecell;
$contentcell = new html_table_cell();
$contentcell->add_class('content');
$contentcell->attributes['class'] = 'content';
$attachedimages = $OUTPUT->container($this->print_attachments(), 'attachments');
@ -299,9 +299,9 @@ class blog_entry {
$table->data = array($mainrow);
if ($return) {
return $OUTPUT->table($table);
return html_writer::table($table);
} else {
echo $OUTPUT->table($table);
echo html_writer::table($table);
}
}