moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 08:56:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-51036 tool_lp: Addressing comments left during peer review

Browse source
This commit is contained in:
Frederic Massart 2016-01-13 17:59:29 +08:00
parent 572721ac1d
commit 182f609213
12 changed files with 59 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

15
admin/tool/lp/lib.php
View file

@ -222,6 +222,7 @@ function tool_lp_comment_add($comment, $params) {
}
// Urls.
// TODO MDL-52749 Replace the link to the plan with the user competency page.
if (empty($plan)) {
$urlname = get_string('userplans', 'tool_lp');
$url = new moodle_url('/admin/tool/lp/plans.php', array('userid' => $uc->get_userid()));
@ -258,8 +259,8 @@ function tool_lp_comment_add($comment, $params) {
$message = new \core\message\message();
$message->component = 'tool_lp';
$message->name = 'user_competency_comment';
$message->notification = 0;
$message->userfrom = $comment->userid;
$message->notification = 1;
$message->userfrom = core_user::get_noreply_user();
$message->subject = get_string('usercommentedonacompetencysubject', 'tool_lp', $fullname);
$message->fullmessage = $fullmessage;
$message->fullmessageformat = $format;
@ -299,8 +300,14 @@ function tool_lp_comment_permissions($params) {
* Validates comments.
*
* @param stdClass $params The parameters.
* @return array
* @return bool
*/
function tool_lp_comment_validate($params) {
return true;
if ($params->commentarea == 'user_competency') {
if (!\tool_lp\user_competency::record_exists($params->itemid)) {
return false;
}
return true;
}
return false;
}