MDL-58138 completion: Fixes for a number of small issues.

This commit is contained in:
Jake Dallimore 2017-04-12 11:50:43 +08:00
parent 32b93ea7f8
commit 273d310601
25 changed files with 90 additions and 146 deletions

View file

@ -15,7 +15,15 @@ information provided here is intended especially for developers.
- mod_<modname>_core_calendar_is_event_visible
- mod_<modname>_core_calendar_provide_event_action
- mod_<modname>_core_calendar_event_action_show_items_acount
* Changes to the moodleform_mod class and its usage (MDL-58138):
- the get_data() method has been overriden. The implementation calls parent::get_data() and a new data_postprocessing() method
- new data_postprocessing() method added. Mods can override this in their mod_form subclass to modify the submit data. Previously
mods could only modify submitted data by overriding get_data() in the mod_form subclass. data_postprocessing() is now the way to
do this correctly.
- completion: \core_completion\manager calls the overriden mod_x_mod_form->data_postprocessing() to allow mods to modify their
completion data before saving the bulk completion form. If you've overriden get_data() to modify submit data for completion in
the past, you should now override the data_postprocessing() method in your mod_form and move your code there, so bulk completion
editing will be properly supported for your plugin.
=== 3.2 ===
* Callback delete_course is deprecated and should be replaced with observer for event \core\event\course_content_deleted