moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-10 03:16:42 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-84042 mod_assign: Notification helper tests cleanup

Browse source
This commit is contained in:
Huong Nguyen 2025-01-08 09:18:41 +07:00
parent 7324de2320
commit 27e2c0bd81
No known key found for this signature in database
GPG key ID: 40D88AB693A3E72A
2 changed files with 13 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
mod/assign/tests/generator/lib.php
View file

@ -126,7 +126,6 @@ class mod_assign_generator extends testing_module_generator {
if (array_key_exists($pluginname, $data)) { if (array_key_exists($pluginname, $data)) {
$plugingenerator = $this->datagenerator->get_plugin_generator("assignsubmission_{$pluginname}"); $plugingenerator = $this->datagenerator->get_plugin_generator("assignsubmission_{$pluginname}");
$plugingenerator->add_submission_data($submission, $assign, $data); $plugingenerator->add_submission_data($submission, $assign, $data);
$plugin->enable();
} }
} }

13
mod/assign/tests/notification_helper_test.php
View file

@ -107,6 +107,7 @@ final class notification_helper_test extends \advanced_testcase {
'course' => $course->id, 'course' => $course->id,
'duedate' => $duedate, 'duedate' => $duedate,
'submissiondrafts' => 0, 'submissiondrafts' => 0,
'assignsubmission_onlinetext_enabled' => 1,
]); ]);
// User1 will have a user override, giving them an extra 1 hour for 'duedate'. // User1 will have a user override, giving them an extra 1 hour for 'duedate'.
@ -142,6 +143,7 @@ final class notification_helper_test extends \advanced_testcase {
'status' => 'submitted', 'status' => 'submitted',
'timemodified' => $clock->time(), 'timemodified' => $clock->time(),
'onlinetext' => 'Some text', 'onlinetext' => 'Some text',
'assignsubmission_onlinetext_enabled' => 1,
]); ]);
// There should be 3 users with the teacher excluded. // There should be 3 users with the teacher excluded.
@ -174,6 +176,7 @@ final class notification_helper_test extends \advanced_testcase {
'course' => $course->id, 'course' => $course->id,
'duedate' => $duedate, 'duedate' => $duedate,
'submissiondrafts' => 0, 'submissiondrafts' => 0,
'assignsubmission_onlinetext_enabled' => 1,
]); ]);
$clock->bump(5); $clock->bump(5);
@ -337,6 +340,7 @@ final class notification_helper_test extends \advanced_testcase {
'course' => $course->id, 'course' => $course->id,
'duedate' => $duedate, 'duedate' => $duedate,
'submissiondrafts' => 0, 'submissiondrafts' => 0,
'assignsubmission_onlinetext_enabled' => 1,
]); ]);
// User1 will have a user override, giving them an extra minute for 'duedate'. // User1 will have a user override, giving them an extra minute for 'duedate'.
@ -373,6 +377,7 @@ final class notification_helper_test extends \advanced_testcase {
'status' => 'submitted', 'status' => 'submitted',
'timemodified' => $clock->time(), 'timemodified' => $clock->time(),
'onlinetext' => 'Some text', 'onlinetext' => 'Some text',
'assignsubmission_onlinetext_enabled' => 1,
]); ]);
// User6 will have a cut-off date override that has already lapsed, excluding them from the results. // User6 will have a cut-off date override that has already lapsed, excluding them from the results.
@ -416,6 +421,7 @@ final class notification_helper_test extends \advanced_testcase {
'duedate' => $duedate, 'duedate' => $duedate,
'cutoffdate' => $cutoffdate, 'cutoffdate' => $cutoffdate,
'submissiondrafts' => 0, 'submissiondrafts' => 0,
'assignsubmission_onlinetext_enabled' => 1,
]); ]);
$clock->bump(5); $clock->bump(5);
@ -490,6 +496,7 @@ final class notification_helper_test extends \advanced_testcase {
'status' => 'submitted', 'status' => 'submitted',
'timemodified' => $clock->time(), 'timemodified' => $clock->time(),
'onlinetext' => 'Some text', 'onlinetext' => 'Some text',
'assignsubmission_onlinetext_enabled' => 1,
]); ]);
// Clear sink. // Clear sink.
@ -551,6 +558,7 @@ final class notification_helper_test extends \advanced_testcase {
'course' => $course->id, 'course' => $course->id,
'duedate' => $duedate, 'duedate' => $duedate,
'submissiondrafts' => 0, 'submissiondrafts' => 0,
'assignsubmission_onlinetext_enabled' => 1,
]); ]);
// User1 will have a user override, giving them an extra 1 day for 'duedate', excluding them from the results. // User1 will have a user override, giving them an extra 1 day for 'duedate', excluding them from the results.
@ -579,6 +587,7 @@ final class notification_helper_test extends \advanced_testcase {
'status' => 'submitted', 'status' => 'submitted',
'timemodified' => $clock->time(), 'timemodified' => $clock->time(),
'onlinetext' => 'Some text', 'onlinetext' => 'Some text',
'assignsubmission_onlinetext_enabled' => 1,
]); ]);
// There should be 1 user with the teacher excluded. // There should be 1 user with the teacher excluded.
@ -610,18 +619,21 @@ final class notification_helper_test extends \advanced_testcase {
'course' => $course->id, 'course' => $course->id,
'duedate' => $duedate1, 'duedate' => $duedate1,
'submissiondrafts' => 0, 'submissiondrafts' => 0,
'assignsubmission_onlinetext_enabled' => 1,
]); ]);
$duedate2 = $clock->time() + WEEKSECS; $duedate2 = $clock->time() + WEEKSECS;
$assignment2 = $assignmentgenerator->create_instance([ $assignment2 = $assignmentgenerator->create_instance([
'course' => $course->id, 'course' => $course->id,
'duedate' => $duedate2, 'duedate' => $duedate2,
'submissiondrafts' => 0, 'submissiondrafts' => 0,
'assignsubmission_onlinetext_enabled' => 1,
]); ]);
$duedate3 = $clock->time() + WEEKSECS + DAYSECS; $duedate3 = $clock->time() + WEEKSECS + DAYSECS;
$assignment3 = $assignmentgenerator->create_instance([ $assignment3 = $assignmentgenerator->create_instance([
'course' => $course->id, 'course' => $course->id,
'duedate' => $duedate3, 'duedate' => $duedate3,
'submissiondrafts' => 0, 'submissiondrafts' => 0,
'assignsubmission_onlinetext_enabled' => 1,
]); ]);
$clock->bump(5); $clock->bump(5);
@ -675,6 +687,7 @@ final class notification_helper_test extends \advanced_testcase {
'status' => 'submitted', 'status' => 'submitted',
'timemodified' => $clock->time(), 'timemodified' => $clock->time(),
'onlinetext' => 'Some text', 'onlinetext' => 'Some text',
'assignsubmission_onlinetext_enabled' => 1,
]); ]);
$clock->bump(5); $clock->bump(5);