moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-06 09:26:35 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-52821 lti: Change tool_consumer_instance_description to site fullname

Browse source 
And change tool_consumer_instance_name to site shortname
This commit is contained in:
John Okely 2016-03-16 12:04:07 +08:00
parent 3edc162611
commit 2a5bb939c2
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
mod/lti/locallib.php
View file

@ -502,9 +502,9 @@ function lti_build_standard_request($instance, $orgid, $islti2) {
if (!empty($CFG->mod_lti_institution_name)) { if (!empty($CFG->mod_lti_institution_name)) {
$requestparams['tool_consumer_instance_name'] = $CFG->mod_lti_institution_name; $requestparams['tool_consumer_instance_name'] = $CFG->mod_lti_institution_name;
} else { } else {
$requestparams['tool_consumer_instance_name'] = get_site()->fullname; $requestparams['tool_consumer_instance_name'] = get_site()->shortname;
} }
$requestparams['tool_consumer_instance_description'] = html_to_text(get_site()->summary, 0); $requestparams['tool_consumer_instance_description'] = get_site()->fullname;
return $requestparams; return $requestparams;
} }

4
mod/lti/tests/externallib_test.php
View file

@ -95,8 +95,8 @@ class mod_lti_external_testcase extends externallib_advanced_testcase {
self::assertEquals($USER->lastname, $parameters['lis_person_name_family']); self::assertEquals($USER->lastname, $parameters['lis_person_name_family']);
self::assertEquals(fullname($USER), $parameters['lis_person_name_full']); self::assertEquals(fullname($USER), $parameters['lis_person_name_full']);
self::assertEquals($USER->username, $parameters['ext_user_username']); self::assertEquals($USER->username, $parameters['ext_user_username']);
self::assertEquals("This is a LONG front page summary with html, it should exceed more than seventy-five characters.", self::assertEquals("phpunit", $parameters['tool_consumer_instance_name']);
$parameters['tool_consumer_instance_description']); self::assertEquals("PHPUnit test site", $parameters['tool_consumer_instance_description']);
} }