moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-04 16:36:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-79477 tool_moodlenet: better handling of network download test.

Browse source 
We can't assume the presense of `Content-Length` header in response
to a HEAD request. Modify test assertion to account for this.
This commit is contained in:
Paul Holden 2023-09-26 11:14:46 +01:00
parent 83b4c96cad
commit 2aa56c770d
No known key found for this signature in database
GPG key ID: A81A96D6045F6164
1 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

10
admin/tool/moodlenet/tests/local/remote_resource_test.php
View file

@ -98,7 +98,15 @@ class remote_resource_test extends \advanced_testcase {
] ]
); );
$this->assertGreaterThan(0, $remoteres->get_download_size()); // We need to handle size of -1 (missing "Content-Length" header), or where it is set and greater than zero.
$this->assertThat(
$remoteres->get_download_size(),
$this->logicalOr(
$this->equalTo(-1),
$this->greaterThan(0),
),
);
[$path, $name] = $remoteres->download_to_requestdir(); [$path, $name] = $remoteres->download_to_requestdir();
$this->assertIsString($path); $this->assertIsString($path);
$this->assertEquals('test.html', $name); $this->assertEquals('test.html', $name);