moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-04 16:36:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-72075 qbank_statistics: fix coding style

Browse source
This commit is contained in:
Nathan Nguyen 2021-11-03 13:53:01 +11:00
parent 341e3079fc
commit 2fcc93981f
6 changed files with 52 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

8
question/bank/statistics/classes/columns/discrimination_index.php
View file

@ -29,14 +29,18 @@ use qbank_statistics\helper;
class discrimination_index extends column_base {
/**
* {@inheritdoc}
* Title for this column.
*
* @return string column title
*/
protected function get_title(): string {
return get_string('discrimination_index', 'qbank_statistics');
}
/**
* {@inheritdoc}
* Column name.
*
* @return string column name
*/
public function get_name(): string {
return 'discrimination_index';

8
question/bank/statistics/classes/columns/discriminative_efficiency.php
View file

@ -29,14 +29,18 @@ use qbank_statistics\helper;
class discriminative_efficiency extends column_base {
/**
* {@inheritdoc}
* Title for this column.
*
* @return string column title
*/
protected function get_title(): string {
return get_string('discriminative_efficiency', 'qbank_statistics');
}
/**
* {@inheritdoc}
* Column name.
*
* @return string column name
*/
public function get_name(): string {
return 'discriminative_efficiency';

9
question/bank/statistics/classes/columns/facility_index.php
View file

@ -29,14 +29,19 @@ use qbank_statistics\helper;
class facility_index extends column_base {
/**
* {@inheritdoc}
* Title for this column.
*
* @return string column title
*/
protected function get_title(): string {
return get_string('facility_index', 'qbank_statistics');
}
/**
* {@inheritdoc}
* Column name.
*
* @return string column name
*/
public function get_name(): string {
return 'facility_index';

11
question/bank/statistics/classes/helper.php
View file

@ -16,14 +16,17 @@
namespace qbank_statistics;
use core_question\statistics\questions\all_calculated_for_qubaid_condition;
use quiz_statistics_report;
defined('MOODLE_INTERNAL') || die();
require_once($CFG->dirroot . '/mod/quiz/report/statistics/statisticslib.php');
require_once($CFG->dirroot . '/mod/quiz/report/default.php');
require_once($CFG->dirroot . '/mod/quiz/report/statistics/report.php');
require_once($CFG->dirroot . '/mod/quiz/report/reportlib.php');
require_once($CFG->dirroot . '/mod/quiz/attemptlib.php');
use core_question\statistics\questions\all_calculated_for_qubaid_condition;
use quiz_statistics_report;
/**
* Helper for statistics
*
@ -59,7 +62,9 @@ class helper {
FROM {quiz_attempts} qa
JOIN {question_usages} qu ON qu.id = qa.uniqueid
JOIN {question_attempts} qatt ON qatt.questionusageid = qu.id
WHERE qatt.questionid = :questionid", ['questionid' => $questionid]);
WHERE qatt.questionid = :questionid",
['questionid' => $questionid]
);
return $quizzes;
}

5
question/bank/statistics/classes/privacy/provider.php
View file

@ -25,8 +25,11 @@ namespace qbank_statistics\privacy;
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class provider implements \core_privacy\local\metadata\null_provider {
/**
* {@inheritdoc}
* Explain why qbank_statistics store no data
*
* @return string reason why this plugin store no data
*/
public static function get_reason(): string {
return 'privacy:metadata';

30
question/bank/statistics/tests/helper_test.php
View file

@ -295,9 +295,13 @@ class helper_test extends \advanced_testcase {
* @param array $expectedquiz2facilities expected quiz 2 facilities
* @param array $expectedaveragefacilities expected average facilities
*/
public function test_load_question_facility(array $quiz1attempts, array $expectedquiz1facilities,
array $quiz2attempts, array $expectedquiz2facilities,
array $expectedaveragefacilities): void {
public function test_load_question_facility(
array $quiz1attempts,
array $expectedquiz1facilities,
array $quiz2attempts,
array $expectedquiz2facilities,
array $expectedaveragefacilities)
: void {
$this->resetAfterTest();
list($quiz1, $quiz2, $questions) = $this->prepare_and_submit_quizzes($quiz1attempts, $quiz2attempts);
@ -371,9 +375,13 @@ class helper_test extends \advanced_testcase {
* @param array $expectedquiz2discriminativeefficiency expected quiz 2 discriminative efficiency
* @param array $expectedaveragediscriminativeefficiency expected average discriminative efficiency
*/
public function test_load_question_discriminative_efficiency(array $quiz1attempts, array $expectedquiz1discriminativeefficiency,
array $quiz2attempts, array $expectedquiz2discriminativeefficiency,
array $expectedaveragediscriminativeefficiency): void {
public function test_load_question_discriminative_efficiency(
array $quiz1attempts,
array $expectedquiz1discriminativeefficiency,
array $quiz2attempts,
array $expectedquiz2discriminativeefficiency,
array $expectedaveragediscriminativeefficiency
): void {
$this->resetAfterTest();
list($quiz1, $quiz2, $questions) = $this->prepare_and_submit_quizzes($quiz1attempts, $quiz2attempts);
@ -471,9 +479,13 @@ class helper_test extends \advanced_testcase {
* @param array $expectedquiz2discriminationindex expected quiz 2 discrimination index
* @param array $expectedaveragediscriminationindex expected average discrimination index
*/
public function test_load_question_discrimination_index(array $quiz1attempts, array $expectedquiz1discriminationindex,
array $quiz2attempts, array $expectedquiz2discriminationindex,
array $expectedaveragediscriminationindex): void {
public function test_load_question_discrimination_index(
array $quiz1attempts,
array $expectedquiz1discriminationindex,
array $quiz2attempts,
array $expectedquiz2discriminationindex,
array $expectedaveragediscriminationindex
): void {
$this->resetAfterTest();
list($quiz1, $quiz2, $questions) = $this->prepare_and_submit_quizzes($quiz1attempts, $quiz2attempts);