MDL-3633 Further refinement.

This commit is contained in:
tjhunt 2008-09-04 09:27:19 +00:00
parent 152d3c0242
commit 316defd2d3

View file

@ -181,8 +181,7 @@
$markcolumn = $gradecolumn && ($quiz->grade != $quiz->sumgrades); $markcolumn = $gradecolumn && ($quiz->grade != $quiz->sumgrades);
$overallstats = $alloptions->scores; $overallstats = $alloptions->scores;
$feedbackcolumn = quiz_has_feedback($quiz->id); $feedbackcolumn = quiz_has_feedback($quiz->id) && $alloptions->overallfeedback;
$overallfeedback = $feedbackcolumn && $alloptions->overallfeedback;
// Prepare table header // Prepare table header
$table->class = 'generaltable quizattemptsummary'; $table->class = 'generaltable quizattemptsummary';
@ -330,7 +329,7 @@
$resultinfo .= print_heading(get_string('comment', 'quiz'), '', 3, 'main', true); $resultinfo .= print_heading(get_string('comment', 'quiz'), '', 3, 'main', true);
$resultinfo .= '<p class="quizteacherfeedback">'.$gradebookfeedback."</p>\n"; $resultinfo .= '<p class="quizteacherfeedback">'.$gradebookfeedback."</p>\n";
} }
if ($overallfeedback) { if ($feedbackcolumn) {
$resultinfo .= print_heading(get_string('overallfeedback', 'quiz'), '', 3, 'main', true); $resultinfo .= print_heading(get_string('overallfeedback', 'quiz'), '', 3, 'main', true);
$resultinfo .= '<p class="quizgradefeedback">'.quiz_feedback_for_grade($mygrade, $quiz->id)."</p>\n"; $resultinfo .= '<p class="quizgradefeedback">'.quiz_feedback_for_grade($mygrade, $quiz->id)."</p>\n";
} }