From 3220058b14dfc84ac8529695b1af708be60f9a1e Mon Sep 17 00:00:00 2001 From: Aaron Barnes Date: Sun, 7 Apr 2013 00:00:05 +1300 Subject: [PATCH] MDL-38011 completion: Use new localised role names --- completion/criteria/completion_criteria_role.php | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/completion/criteria/completion_criteria_role.php b/completion/criteria/completion_criteria_role.php index 5b2d051cd00..cb8c57c00b1 100644 --- a/completion/criteria/completion_criteria_role.php +++ b/completion/criteria/completion_criteria_role.php @@ -59,7 +59,7 @@ class completion_criteria_role extends completion_criteria { */ public function config_form_display(&$mform, $data = null) { - $mform->addElement('checkbox', 'criteria_role['.$data->id.']', $data->name); + $mform->addElement('checkbox', 'criteria_role['.$data->id.']', $this->get_title($data)); if ($this->id) { $mform->setDefault('criteria_role['.$data->id.']', 1); @@ -122,8 +122,8 @@ class completion_criteria_role extends completion_criteria { */ public function get_title() { global $DB; - $role = $DB->get_field('role', 'name', array('id' => $this->role)); - return $role; + $role = $DB->get_record('role', array('id' => $this->role)); + return role_get_name($role, context_course::instance($this->course)); } /** @@ -132,8 +132,7 @@ class completion_criteria_role extends completion_criteria { * @return string */ public function get_title_detailed() { - global $DB; - return $DB->get_field('role', 'name', array('id' => $this->role)); + return $this->get_title(); } /**