From 383fc1fbae9a2b5a16178bdef67f791b5728eafa Mon Sep 17 00:00:00 2001 From: sam marshall Date: Wed, 13 Jun 2012 16:45:42 +0100 Subject: [PATCH] MDL-33426 Completion: Multilang activity names wrong in alt/title --- course/lib.php | 10 +++++----- report/progress/index.php | 3 ++- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/course/lib.php b/course/lib.php index 3384bf3db41..a999eb4dc60 100644 --- a/course/lib.php +++ b/course/lib.php @@ -1515,9 +1515,8 @@ function print_section($course, $section, $mods, $modnamesused, $absolute=false, // 2. the activity has dates set which do not include current, or // 3. the activity has any other conditions set (regardless of whether // current user meets them) - $canviewhidden = has_capability( - 'moodle/course:viewhiddenactivities', - get_context_instance(CONTEXT_MODULE, $mod->id)); + $modcontext = context_module::instance($mod->id); + $canviewhidden = has_capability('moodle/course:viewhiddenactivities', $modcontext); $accessiblebutdim = false; if ($canviewhidden) { $accessiblebutdim = !$mod->visible; @@ -1733,9 +1732,10 @@ function print_section($course, $section, $mods, $modnamesused, $absolute=false, } if ($completionicon) { $imgsrc = $OUTPUT->pix_url('i/completion-'.$completionicon); - $imgalt = s(get_string('completion-alt-'.$completionicon, 'completion', $mod->name)); + $formattedname = format_string($mod->name, true, array('context' => $modcontext)); + $imgalt = get_string('completion-alt-' . $completionicon, 'completion', $formattedname); if ($completion == COMPLETION_TRACKING_MANUAL && !$isediting) { - $imgtitle = s(get_string('completion-title-'.$completionicon, 'completion', $mod->name)); + $imgtitle = get_string('completion-title-' . $completionicon, 'completion', $formattedname); $newstate = $completiondata->completionstate==COMPLETION_COMPLETE ? COMPLETION_INCOMPLETE diff --git a/report/progress/index.php b/report/progress/index.php index 1f0b452c109..24e7aa049ac 100644 --- a/report/progress/index.php +++ b/report/progress/index.php @@ -388,12 +388,13 @@ foreach($progress as $user) { ($activity->completion==COMPLETION_TRACKING_AUTOMATIC ? 'auto' : 'manual'). '-'.$completiontype; + $modcontext = context_module::instance($activity->id); $describe = get_string('completion-' . $completiontype, 'completion'); $a=new StdClass; $a->state=$describe; $a->date=$date; $a->user=fullname($user); - $a->activity=strip_tags($activity->name); + $a->activity = format_string($activity->name, true, array('context' => $modcontext)); $fulldescribe=get_string('progress-title','completion',$a); if ($csv) {