From c386f35bca36ee4d340722b9130840184a8a9bac Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20=C5=A0koda?= Date: Thu, 13 Mar 2014 13:52:31 +0800 Subject: [PATCH] MDL-44339 treat unexpected debugging() calls in phpunit tests as errors --- lib/phpunit/classes/advanced_testcase.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/phpunit/classes/advanced_testcase.php b/lib/phpunit/classes/advanced_testcase.php index 04bd7917b5e..511f945ec82 100644 --- a/lib/phpunit/classes/advanced_testcase.php +++ b/lib/phpunit/classes/advanced_testcase.php @@ -82,8 +82,11 @@ abstract class advanced_testcase extends PHPUnit_Framework_TestCase { $DB = phpunit_util::get_global_backup('DB'); // Deal with any debugging messages. - phpunit_util::display_debugging_messages(); + $debugerror = phpunit_util::display_debugging_messages(); phpunit_util::reset_debugging(); + if ($debugerror) { + trigger_error('Unenxpected debugging() call detected.', E_USER_NOTICE); + } } catch (Exception $e) { // cleanup after failed expectation