moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-11 03:46:42 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge branch 'MDL-79148-master' of https://github.com/ssj365/moodle

Browse source
This commit is contained in:
Jun Pataleta 2023-11-29 15:20:44 +08:00
commit 3bdbedb79a
No known key found for this signature in database
GPG key ID: F83510526D99E2C7
2 changed files with 35 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
mod/bigbluebuttonbn/classes/output/recording_row_playback.php
View file

@ -108,10 +108,6 @@ class recording_row_playback implements renderable, templatable {
return true;
}
// Exclude imported recordings.
if ($this->recording->get('imported')) {
return false;
}
$canmanagerecordings = roles::has_capability_in_course(
$this->recording->get('courseid'), 'mod/bigbluebuttonbn:managerecordings');
$canviewallformats = roles::has_capability_in_course(

35
mod/bigbluebuttonbn/tests/output/recording_row_playback_test.php
View file

@ -148,4 +148,39 @@ class recording_row_playback_test extends \advanced_testcase {
];
}
/**
* Test recording link is rendered for imported recordings.
*
* @return void
* @covers \recording_row_playback::should_be_included
*/
public function test_show_recording_links(): void {
global $PAGE;
$this->resetAfterTest();
set_config('bigbluebuttonbn_importrecordings_enabled', 1);
$plugingenerator = $this->getDataGenerator()->get_plugin_generator('mod_bigbluebuttonbn');
['recordings' => $recordingsdata, 'activity' => $activity] = $this->create_activity_with_recordings(
$this->get_course(),
instance::TYPE_ALL,
self::RECORDING_DATA
);
$recording = new recording(0, $recordingsdata[0]);
$instance = instance::get_from_instanceid($activity->id);
// Now create a new activity and import the recording.
$newactivity = $plugingenerator->create_instance([
'course' => $instance->get_course_id(),
'type' => instance::TYPE_ALL,
'name' => 'Example 2',
]);
$plugingenerator->create_meeting([
'instanceid' => $newactivity->id,
]);
$newinstance = instance::get_from_instanceid($newactivity->id);
// Import recording into new instance.
$importedrecording = $recording->create_imported_recording($newinstance);
$importedrowplayback = new recording_row_playback($importedrecording, $newinstance);
$importedrowinfo = $importedrowplayback->export_for_template($PAGE->get_renderer('mod_bigbluebuttonbn'));
$this->assertNotEmpty($importedrowinfo->playbacks);
}
}