moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-06 17:36:38 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Another improvement on regrading. The code thought that grading for a question changed if the grade was like 1/3. The precision in the database is different than the newly calculated grade, so now we round both values to 5 decimal places, which should fix this problem. This was committed to STABLE by Julian a long time ago

Browse source
This commit is contained in:
gustav_delius 2006-02-06 23:25:15 +00:00
parent 27aa2243ea
commit 3bf0212c24
1 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
mod/quiz/questionlib.php
View file

@ -510,10 +510,13 @@ function quiz_regrade_question_in_attempt($question, $attempt, $cmoptions, $verb
$attempt)) { $attempt)) {
$verbose && notify("Couldn't regrade state #{$state->id}!"); $verbose && notify("Couldn't regrade state #{$state->id}!");
} }
if ((float)$replaystate->raw_grade != (float)$states[$j]->raw_grade) {
$changed++;
// We need rounding here because grades in the DB get truncated
// e.g. 0.33333 != 0.3333333, but we want them to be equal here
if (round((float)$replaystate->grade, 5) != round((float)$states[$j]->grade, 5)) {
$changed++;
} }
$replaystate->id = $states[$j]->id; $replaystate->id = $states[$j]->id;
$replaystate->update = true; $replaystate->update = true;
quiz_save_question_session($question, $replaystate); quiz_save_question_session($question, $replaystate);