moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-04 08:26:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-24085 - unused tablelib where in show_nonrespondents.php

Browse source
This commit is contained in:
Andreas Grabs 2010-09-05 19:53:15 +00:00
parent 2361b7dd77
commit 3fac763e5f
2 changed files with 5 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

2
mod/feedback/lib.php
View file

@ -736,7 +736,7 @@ function feedback_get_incomplete_users($cm, $group = false, $sort = '', $startpa
//now get all completeds //now get all completeds
if(!$completedusers = $DB->get_records_menu('feedback_completed', array('feedback'=>$cm->instance), '', 'userid,id')){ if(!$completedusers = $DB->get_records_menu('feedback_completed', array('feedback'=>$cm->instance), '', 'userid,id')){
return false; return $allusers;
} }
$completedusers = array_keys($completedusers); $completedusers = array_keys($completedusers);

13
mod/feedback/show_nonrespondents.php
View file

@ -19,8 +19,8 @@
$subject = optional_param('subject','',PARAM_CLEANHTML); $subject = optional_param('subject','',PARAM_CLEANHTML);
$message = optional_param('message','',PARAM_CLEANHTML); $message = optional_param('message','',PARAM_CLEANHTML);
$format = optional_param('format',FORMAT_MOODLE,PARAM_INT); $format = optional_param('format',FORMAT_MOODLE,PARAM_INT);
$messageuser = optional_param('messageuser',PARAM_INT); $messageuser = optional_param('messageuser', false, PARAM_INT);
$action = optional_param('action',PARAM_ALPHA); $action = optional_param('action', '',PARAM_ALPHA);
$perpage = optional_param('perpage', FEEDBACK_DEFAULT_PAGE_COUNT, PARAM_INT); // how many per page $perpage = optional_param('perpage', FEEDBACK_DEFAULT_PAGE_COUNT, PARAM_INT); // how many per page
$showall = optional_param('showall', false, PARAM_INT); // should we show all users $showall = optional_param('showall', false, PARAM_INT); // should we show all users
// $SESSION->feedback->current_tab = $do_show; // $SESSION->feedback->current_tab = $do_show;
@ -68,7 +68,7 @@
require_capability('mod/feedback:viewreports', $context); require_capability('mod/feedback:viewreports', $context);
if(has_capability('moodle/course:bulkmessaging', $coursecontext)) { if($action == 'sendmessage' AND has_capability('moodle/course:bulkmessaging', $coursecontext)) {
// require_once($CFG->dirroot.'/message/lib.php'); // require_once($CFG->dirroot.'/message/lib.php');
$good = 1; $good = 1;
if(is_array($messageuser)) { if(is_array($messageuser)) {
@ -169,11 +169,6 @@
$sort = ''; $sort = '';
} }
list($where, $params) = $table->get_sql_where(); //TODO: weird, $where not used anywhere
if ($where) {
$where .= ' AND';
}
//get students in conjunction with groupmode //get students in conjunction with groupmode
if($groupmode > 0) { if($groupmode > 0) {
if($mygroupid > 0) { if($mygroupid > 0) {
@ -197,7 +192,7 @@
$pagecount = $table->get_page_size(); $pagecount = $table->get_page_size();
} }
$students = feedback_get_incomplete_users($cm, $usedgroupid, $sort, $startpage, $pagecount); // TODO: $where and $params should be probably used here $students = feedback_get_incomplete_users($cm, $usedgroupid, $sort, $startpage, $pagecount);
//####### viewreports-start //####### viewreports-start
//print the list of students //print the list of students
echo $OUTPUT->box_start('generalbox boxaligncenter boxwidthwide'); echo $OUTPUT->box_start('generalbox boxaligncenter boxwidthwide');