moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 00:46:50 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-13904 Scorm structure isn't respected after an update of the package. This is a large change to the handling of SCORM package update - all SCOes are issued with a new id, and all references to the old ones are deleted. The scorm_scoes_track data is preserved by being reattached to the new SCO ids (unless they have been deleted).

Browse source
This commit is contained in:
piers 2008-08-13 00:11:53 +00:00
parent f5ca89f8b9
commit 3fd25520c0
1 changed files with 16 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

13
mod/scorm/datamodels/scormlib.php
View file

@ -488,14 +488,10 @@ function scorm_parse_scorm($pkgdir,$scormid) {
$newitem->$standarddata = $item->$standarddata; $newitem->$standarddata = $item->$standarddata;
} }
$id = 0; // Insert the new SCO, and retain the link between the old and new for later adjustment
if (!empty($olditems) && ($olditemid = scorm_array_search('identifier',$newitem->identifier,$olditems))) {
$newitem->id = $olditemid;
$id = $DB->update_record('scorm_scoes',$newitem);
unset($olditems[$olditemid]);
$DB->delete_records('scorm_scoes_data', array('scoid'=>$olditemid));
} else {
$id = $DB->insert_record('scorm_scoes',$newitem); $id = $DB->insert_record('scorm_scoes',$newitem);
if (!empty($olditems) && ($olditemid = scorm_array_search('identifier',$newitem->identifier,$olditems))) {
$olditems[$olditemid]->newid = $id;
} }
if ($optionaldatas = scorm_optionals_data($item,$standarddatas)) { if ($optionaldatas = scorm_optionals_data($item,$standarddatas)) {
@ -592,6 +588,9 @@ function scorm_parse_scorm($pkgdir,$scormid) {
foreach($olditems as $olditem) { foreach($olditems as $olditem) {
$DB->delete_records('scorm_scoes', array('id'=>$olditem->id)); $DB->delete_records('scorm_scoes', array('id'=>$olditem->id));
$DB->delete_records('scorm_scoes_data',array('scoid'=>$olditem->id)); $DB->delete_records('scorm_scoes_data',array('scoid'=>$olditem->id));
if (isset($olditem->newid)) {
$DB->set_field('scorm_scoes_track', 'scoid', $olditem->newid, array('scoid' => $olditem->id));
}
$DB->delete_records('scorm_scoes_track',array('scoid'=>$olditem->id)); $DB->delete_records('scorm_scoes_track',array('scoid'=>$olditem->id));
$DB->delete_records('scorm_seq_objective', array('scoid'=>$olditem->id)); $DB->delete_records('scorm_seq_objective', array('scoid'=>$olditem->id));
$DB->delete_records('scorm_seq_mapinfo', array('scoid'=>$olditem->id)); $DB->delete_records('scorm_seq_mapinfo', array('scoid'=>$olditem->id));