diff --git a/lib/completion/completion_criteria_activity.php b/lib/completion/completion_criteria_activity.php index feb5aa67f9b..803dd94750c 100644 --- a/lib/completion/completion_criteria_activity.php +++ b/lib/completion/completion_criteria_activity.php @@ -228,15 +228,13 @@ class completion_criteria_activity extends completion_criteria { '; // Loop through completions, and mark as complete - if ($rs = $DB->get_recordset_sql($sql)) { - foreach ($rs as $record) { + $rs = $DB->get_recordset_sql($sql); + foreach ($rs as $record) { - $completion = new completion_criteria_completion((array)$record); - $completion->mark_complete($record->timecompleted); - } - - $rs->close(); + $completion = new completion_criteria_completion((array)$record); + $completion->mark_complete($record->timecompleted); } + $rs->close(); } /** diff --git a/lib/completion/completion_criteria_course.php b/lib/completion/completion_criteria_course.php index afafeb52cbf..2107c213fa6 100644 --- a/lib/completion/completion_criteria_course.php +++ b/lib/completion/completion_criteria_course.php @@ -185,14 +185,12 @@ class completion_criteria_course extends completion_criteria { "; // Loop through completions, and mark as complete - if ($rs = $DB->get_recordset_sql($sql)) { - foreach ($rs as $record) { - $completion = new completion_criteria_completion((array)$record); - $completion->mark_complete($record->timecompleted); - } - - $rs->close(); + $rs = $DB->get_recordset_sql($sql); + foreach ($rs as $record) { + $completion = new completion_criteria_completion((array)$record); + $completion->mark_complete($record->timecompleted); } + $rs->close(); } /** diff --git a/lib/completion/completion_criteria_date.php b/lib/completion/completion_criteria_date.php index 9551a8826c0..9bd66a2a6fb 100644 --- a/lib/completion/completion_criteria_date.php +++ b/lib/completion/completion_criteria_date.php @@ -178,15 +178,12 @@ class completion_criteria_date extends completion_criteria { '; // Loop through completions, and mark as complete - if ($rs = $DB->get_recordset_sql($sql, array(time()))) { - foreach ($rs as $record) { - - $completion = new completion_criteria_completion((array)$record); - $completion->mark_complete($record->timeend); - } - - $rs->close(); + $rs = $DB->get_recordset_sql($sql, array(time())); + foreach ($rs as $record) { + $completion = new completion_criteria_completion((array)$record); + $completion->mark_complete($record->timeend); } + $rs->close(); } /** diff --git a/lib/completion/completion_criteria_duration.php b/lib/completion/completion_criteria_duration.php index 96847ecf362..bb4ab66abb0 100644 --- a/lib/completion/completion_criteria_duration.php +++ b/lib/completion/completion_criteria_duration.php @@ -219,22 +219,19 @@ class completion_criteria_duration extends completion_criteria { // Loop through completions, and mark as complete $now = time(); - if ($rs = $DB->get_recordset_sql($sql, array($now, $now))) { - foreach ($rs as $record) { + $rs = $DB->get_recordset_sql($sql, array($now, $now)); + foreach ($rs as $record) { - $completion = new completion_criteria_completion((array)$record); + $completion = new completion_criteria_completion((array)$record); - // Use time start if not 0, otherwise use timeenrolled - if ($record->otimestart) { - $completion->mark_complete($record->ctimestart); - } - else { - $completion->mark_complete($record->ctimeenrolled); - } + // Use time start if not 0, otherwise use timeenrolled + if ($record->otimestart) { + $completion->mark_complete($record->ctimestart); + } else { + $completion->mark_complete($record->ctimeenrolled); } - - $rs->close(); } + $rs->close(); } /** diff --git a/lib/completion/completion_criteria_grade.php b/lib/completion/completion_criteria_grade.php index 985942a2c38..00e75aba568 100644 --- a/lib/completion/completion_criteria_grade.php +++ b/lib/completion/completion_criteria_grade.php @@ -214,15 +214,12 @@ class completion_criteria_grade extends completion_criteria { '; // Loop through completions, and mark as complete - if ($rs = $DB->get_recordset_sql($sql)) { - foreach ($rs as $record) { - - $completion = new completion_criteria_completion((array)$record); - $completion->mark_complete($record->timecompleted); - } - - $rs->close(); + $rs = $DB->get_recordset_sql($sql); + foreach ($rs as $record) { + $completion = new completion_criteria_completion((array)$record); + $completion->mark_complete($record->timecompleted); } + $rs->close(); } /** diff --git a/lib/completion/cron.php b/lib/completion/cron.php index 1c30809f220..281a9d76d25 100644 --- a/lib/completion/cron.php +++ b/lib/completion/cron.php @@ -118,9 +118,12 @@ function completion_cron_mark_started() { userid "; - // Check if result is empty $now = time(); - if (!$rs = $DB->get_recordset_sql($sql, array($now, $now, $now, $now))) { + $rs = $DB->get_recordset_sql($sql, array($now, $now, $now, $now)); + + // Check if result is empty + if (!$rs->valid()) { + $rs->close(); // Not going to iterate (but exit), close rs return; } @@ -267,8 +270,11 @@ function completion_cron_completions() { userid '; + $rs = $DB->get_recordset_sql($sql, array('timestarted' => $timestarted)); + // Check if result is empty - if (!$rs = $DB->get_recordset_sql($sql, array('timestarted' => $timestarted))) { + if (!$rs->valid()) { + $rs->close(); // Not going to iterate (but exit), close rs return; }