moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 00:46:50 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-66626 assignfeedback_editpdf: Check page count for attempt.

Browse source 
Co-Authored-By: John Yao <johnyao@catalyst-au.net>
This commit is contained in:
Mikhail Golenkov 2020-07-20 16:45:13 +10:00
parent 78572f186d
commit 42f75f5a52
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
mod/assign/feedback/editpdf/classes/document_services.php
View file

@ -576,7 +576,9 @@ EOD;
}
}
if (empty($pages)) {
$totalpagesforattempt = self::page_number_for_attempt($assignment, $userid, $attemptnumber, false);
// Here we are comparing the total number of images against the total number of pages from the combined PDF.
if (empty($pages) || count($pages) != $totalpagesforattempt) {
if ($readonly) {
// This should never happen, there should be a version of the pages available
// whenever we are requesting the readonly version.