moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-08 02:16:41 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-66378 behat: JS does not work with newlines in an xpath

Browse source
This commit is contained in:
Andrew Nicols 2019-08-16 11:32:12 +08:00
parent 221bfed37b
commit 460a0a74c4
1 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
lib/tests/behat/behat_general.php
View file

@ -856,8 +856,13 @@ class behat_general extends behat_base {
list($preselector, $prelocator) = $this->transform_selector($preselectortype, $preelement); list($preselector, $prelocator) = $this->transform_selector($preselectortype, $preelement);
list($postselector, $postlocator) = $this->transform_selector($postselectortype, $postelement); list($postselector, $postlocator) = $this->transform_selector($postselectortype, $postelement);
$prexpath = $this->find($preselector, $prelocator, false, $containernode)->getXpath(); $newlines = [
$postxpath = $this->find($postselector, $postlocator, false, $containernode)->getXpath(); "\r\n",
"\r",
"\n",
];
$prexpath = str_replace($newlines, ' ', $this->find($preselector, $prelocator, false, $containernode)->getXpath());
$postxpath = str_replace($newlines, ' ', $this->find($postselector, $postlocator, false, $containernode)->getXpath());
if ($this->running_javascript()) { if ($this->running_javascript()) {
// The xpath to do this was running really slowly on certain Chrome versions so we are using // The xpath to do this was running really slowly on certain Chrome versions so we are using