From 46e2e2020d461a3b576eedc2cfebce042be6d1ec Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Mudr=C3=A1k?= Date: Mon, 6 Dec 2021 21:39:35 +0100 Subject: [PATCH] MDL-73201 lang: Use fixed strings in the tests, too --- ...mpletionstatus_activity_completion.feature | 4 ++-- .../block_course_summary_frontpage.feature | 2 +- .../tests/behat/add_url.feature | 2 +- .../behat/course_download_content_cm.feature | 20 ++++++++-------- .../behat/frontpage_display_modes.feature | 6 ++--- .../behat/frontpage_topic_section.feature | 2 +- .../behat/assign_activity_completion.feature | 2 +- .../bulk_release_anon_submissions.feature | 8 +++---- mod/assign/tests/behat/display_grade.feature | 4 ++-- .../tests/behat/filter_by_marker.feature | 2 +- .../tests/behat/grading_app_filters.feature | 4 ++-- mod/assign/tests/behat/grading_status.feature | 4 ++-- .../tests/behat/steps_blind_marking.feature | 6 ++--- mod/feedback/tests/behat/anonymous.feature | 2 +- .../tests/behat/non_anonymous.feature | 2 +- .../tests/behat/statistics_values.feature | 24 +++++++++---------- 16 files changed, 47 insertions(+), 47 deletions(-) diff --git a/blocks/completionstatus/tests/behat/block_completionstatus_activity_completion.feature b/blocks/completionstatus/tests/behat/block_completionstatus_activity_completion.feature index eee001e9365..a3094956a65 100644 --- a/blocks/completionstatus/tests/behat/block_completionstatus_activity_completion.feature +++ b/blocks/completionstatus/tests/behat/block_completionstatus_activity_completion.feature @@ -81,7 +81,7 @@ Feature: Enable Block Completion in a course using activity completion And I follow "View all submissions" And I click on "Grade" "link" in the "Student" "table_row" And I set the field "Grade out of 100" to "53" - And I set the field "Notify students" to "0" + And I set the field "Notify student" to "0" And I press "Save changes" And I am on "Course 1" course homepage with editing mode on And I add the "Course completion status" block @@ -115,7 +115,7 @@ Feature: Enable Block Completion in a course using activity completion And I follow "View all submissions" And I click on "Grade" "link" in the "Student" "table_row" And I set the field "Grade out of 100" to "49" - And I set the field "Notify students" to "0" + And I set the field "Notify student" to "0" And I press "Save changes" And I am on "Course 1" course homepage with editing mode on And I add the "Course completion status" block diff --git a/blocks/course_summary/tests/behat/block_course_summary_frontpage.feature b/blocks/course_summary/tests/behat/block_course_summary_frontpage.feature index ee6a13ed6b8..7eb6704cfc7 100644 --- a/blocks/course_summary/tests/behat/block_course_summary_frontpage.feature +++ b/blocks/course_summary/tests/behat/block_course_summary_frontpage.feature @@ -9,7 +9,7 @@ Feature: Course summary block used on the frontpage And I am on site homepage And I turn editing mode on And I add the "Course/site summary" block - And I navigate to "Front page > Front page settings" in site administration + And I navigate to "Site home > Site home settings" in site administration And I set the following fields to these values: | summary | Proved the summary block works! | And I press "Save changes" diff --git a/blocks/site_main_menu/tests/behat/add_url.feature b/blocks/site_main_menu/tests/behat/add_url.feature index 082906729ef..573962f8196 100644 --- a/blocks/site_main_menu/tests/behat/add_url.feature +++ b/blocks/site_main_menu/tests/behat/add_url.feature @@ -58,7 +58,7 @@ Feature: Add URL to main menu block And I add the "Main menu" block And I configure the "Main menu" block And I set the following fields to these values: - | Page contexts | Display on the front page and any pages added to the front page | + | Page contexts | Display on the site home and any pages added to the site home. | And I press "Save changes" And I add a "URL" to section "0" and I fill the form with: | Name | reference link | diff --git a/course/tests/behat/course_download_content_cm.feature b/course/tests/behat/course_download_content_cm.feature index 3f84f88cdc3..09409df9c3f 100644 --- a/course/tests/behat/course_download_content_cm.feature +++ b/course/tests/behat/course_download_content_cm.feature @@ -29,30 +29,30 @@ Feature: Activities content download can be controlled | downloadcoursecontentallowed | 1 | And I log out - Scenario: "Include in course downloads (if that feature is enabled)" field default is set to "Yes" if nothing has been set + Scenario: "Include in course content download" field default is set to "Yes" if nothing has been set Given I am on the Page1 "Page Activity editing" page logged in as admin - Then the field "Include in course downloads (if that feature is enabled)" matches value "Yes" + Then the field "Include in course content download" matches value "Yes" - Scenario: "Include in course downloads (if that feature is enabled)" field is not visible if course content is disabled on site level + Scenario: "Include in course content download" field is not visible if course content is disabled on site level Given I log in as "admin" And the following config values are set as admin: | downloadcoursecontentallowed | 0 | And I am on the Page1 "Page Activity editing" page - Then "Include in course downloads (if that feature is enabled)" "select" should not exist + Then "Include in course content download" "select" should not exist - Scenario: "Include in course downloads (if that feature is enabled)" field is visible even if course content is disabled on course level + Scenario: "Include in course content download" field is visible even if course content is disabled on course level Given I log in as "admin" And I am on "Course 1" course homepage And I navigate to "Settings" in current page administration When I set the field "Enable download course content" to "No" And I press "Save and display" And I am on the Page1 "Page Activity editing" page - Then "Include in course downloads (if that feature is enabled)" "select" should exist + Then "Include in course content download" "select" should exist - Scenario: "Include in course downloads (if that feature is enabled)" field should be visible but not editable for users without configuredownloadcontent capability + Scenario: "Include in course content download" field should be visible but not editable for users without configuredownloadcontent capability Given I log in as "manager1" And I am on the Folder1 "Folder Activity editing" page - And "Include in course downloads (if that feature is enabled)" "field" should exist + And "Include in course content download" "field" should exist And I log out And I log in as "admin" When I set the following system permissions of "Manager" role: @@ -61,6 +61,6 @@ Feature: Activities content download can be controlled And I log out And I log in as "manager1" And I am on the Folder1 "Folder Activity editing" page - Then I should see "Include in course downloads (if that feature is enabled)" + Then I should see "Include in course content download" And I should see "No" - And "Include in course downloads (if that feature is enabled)" "select" should not exist + And "Include in course content download" "select" should not exist diff --git a/course/tests/behat/frontpage_display_modes.feature b/course/tests/behat/frontpage_display_modes.feature index f2664bbac30..7df3eff46a2 100644 --- a/course/tests/behat/frontpage_display_modes.feature +++ b/course/tests/behat/frontpage_display_modes.feature @@ -1,5 +1,5 @@ @core @core_course -Feature: Front page displays items in different modes +Feature: Site home displays items in different modes In order to show a clean and clear list of the site categories and course As an admin I need to set different frontpage display modes @@ -27,7 +27,7 @@ Feature: Front page displays items in different modes @javascript Scenario: Displays a list of categories When I set the following administration settings values: - | Front page items when logged in | List of categories | + | Site home items when logged in | List of categories | | Maximum category depth | 2 | And I am on site homepage Then I should see "Category A" in the "region-main" "region" @@ -43,7 +43,7 @@ Feature: Front page displays items in different modes @javascript Scenario: Displays a combo list When I set the following administration settings values: - | Front page items when logged in | Combo list | + | Site home items when logged in | Combo list | | Maximum category depth | 2 | And I am on site homepage Then I should see "Category A" in the "region-main" "region" diff --git a/course/tests/behat/frontpage_topic_section.feature b/course/tests/behat/frontpage_topic_section.feature index 5c9bbfb9385..7ea81a57a3d 100644 --- a/course/tests/behat/frontpage_topic_section.feature +++ b/course/tests/behat/frontpage_topic_section.feature @@ -1,5 +1,5 @@ @core @core_course -Feature: Front page topic section +Feature: Site home topic section In order to show a display activities in the frontpage As an admin I need to edit the frontpage topic section diff --git a/mod/assign/tests/behat/assign_activity_completion.feature b/mod/assign/tests/behat/assign_activity_completion.feature index 099ad809bba..92bccc5ff8e 100644 --- a/mod/assign/tests/behat/assign_activity_completion.feature +++ b/mod/assign/tests/behat/assign_activity_completion.feature @@ -115,7 +115,7 @@ Feature: View activity completion in the assignment activity And I follow "View all submissions" And I click on "Grade" "link" in the "Vinnie Student1" "table_row" And I set the field "Grade out of 100" to "33" - And I set the field "Notify students" to "0" + And I set the field "Notify student" to "0" And I press "Save changes" And I follow "View all submissions" And I log out diff --git a/mod/assign/tests/behat/bulk_release_anon_submissions.feature b/mod/assign/tests/behat/bulk_release_anon_submissions.feature index 4bda24e7c05..af8c9469385 100644 --- a/mod/assign/tests/behat/bulk_release_anon_submissions.feature +++ b/mod/assign/tests/behat/bulk_release_anon_submissions.feature @@ -57,7 +57,7 @@ Feature: Bulk released grades should not be sent to gradebook while submissions And I set the field "Grade out of 100" to "50" And I set the field "Marking workflow state" to "In review" And I set the field "Feedback comments" to "Great job!" - And I set the field "Notify students" to "0" + And I set the field "Notify student" to "0" And I press "Save changes" And I am on the "Test assignment name" "assign activity" page And I follow "View all submissions" @@ -66,7 +66,7 @@ Feature: Bulk released grades should not be sent to gradebook while submissions And I set the field "Grade out of 100" to "50" And I set the field "Marking workflow state" to "In review" And I set the field "Feedback comments" to "Great job!" - And I set the field "Notify students" to "0" + And I set the field "Notify student" to "0" And I press "Save changes" And I am on the "Test assignment name" "assign activity" page And I follow "View all submissions" @@ -81,7 +81,7 @@ Feature: Bulk released grades should not be sent to gradebook while submissions Then I should not see "Student 1 (student1@example.com)" And I should not see "Student 2 (student2@example.com)" And I set the field "Marking workflow state" to "Released" - And I set the field "Notify students" to "No" + And I set the field "Notify student" to "No" And I press "Save changes" And I am on the "Test assignment name" "assign activity" page And I follow "View all submissions" @@ -129,7 +129,7 @@ Feature: Bulk released grades should not be sent to gradebook while submissions Then I should see "Student 1 (student1@example.com)" And I should see "Student 2 (student2@example.com)" And I set the field "Marking workflow state" to "Released" - And I set the field "Notify students" to "No" + And I set the field "Notify student" to "No" And I press "Save changes" And I am on the "Test assignment name" "assign activity" page And I follow "View all submissions" diff --git a/mod/assign/tests/behat/display_grade.feature b/mod/assign/tests/behat/display_grade.feature index a57602be3b6..022a75b3c1c 100644 --- a/mod/assign/tests/behat/display_grade.feature +++ b/mod/assign/tests/behat/display_grade.feature @@ -31,7 +31,7 @@ Feature: Check that the assignment grade can be updated correctly Then I follow "View all submissions" And I click on "Grade" "link" in the "Student 1" "table_row" And I set the field "Grade out of 100" to "50" - And I set the field "Notify students" to "0" + And I set the field "Notify student" to "0" And I press "Save changes" And I follow "View all submissions" And "Student 1" row "Grade" column of "generaltable" table should contain "50.00" @@ -65,7 +65,7 @@ Feature: Check that the assignment grade can be updated correctly When I follow "View all submissions" And I click on "Grade" "link" in the "Student 1" "table_row" And I set the field "Grade out of 100" to "50" - And I set the field "Notify students" to "0" + And I set the field "Notify student" to "0" And I press "Save changes" And I follow "View all submissions" Then "Student 1" row "Grade" column of "generaltable" table should contain "50.00" diff --git a/mod/assign/tests/behat/filter_by_marker.feature b/mod/assign/tests/behat/filter_by_marker.feature index 23a11598c4a..c3780ab2f81 100644 --- a/mod/assign/tests/behat/filter_by_marker.feature +++ b/mod/assign/tests/behat/filter_by_marker.feature @@ -35,7 +35,7 @@ Feature: In an assignment, teachers can filter displayed submissions by assigned And I follow "View all submissions" And I click on "Grade" "link" in the "Student 1" "table_row" And I set the field "allocatedmarker" to "Marker 1" - And I set the field "Notify students" to "0" + And I set the field "Notify student" to "0" And I press "Save changes" And I click on "Edit settings" "link" diff --git a/mod/assign/tests/behat/grading_app_filters.feature b/mod/assign/tests/behat/grading_app_filters.feature index 5f77eb2b16a..c483438d9b2 100644 --- a/mod/assign/tests/behat/grading_app_filters.feature +++ b/mod/assign/tests/behat/grading_app_filters.feature @@ -42,7 +42,7 @@ Feature: In an assignment, teachers can change filters in the grading app And I should not see "Test assignment name &" And I set the field "allocatedmarker" to "Marker 1" And I set the field "workflowstate" to "In marking" - And I set the field "Notify students" to "0" + And I set the field "Notify student" to "0" And I press "Save changes" And I am on the "Test assignment name &" Activity page @@ -62,7 +62,7 @@ Feature: In an assignment, teachers can change filters in the grading app And I click on "Grade" "link" in the "Student 1" "table_row" And I set the field "allocatedmarker" to "Marker 1" And I set the field "workflowstate" to "In marking" - And I set the field "Notify students" to "0" + And I set the field "Notify student" to "0" And I press "Save changes" And I am on the "Test assignment name &" Activity page diff --git a/mod/assign/tests/behat/grading_status.feature b/mod/assign/tests/behat/grading_status.feature index 1a3e006748f..4b0c438f38a 100644 --- a/mod/assign/tests/behat/grading_status.feature +++ b/mod/assign/tests/behat/grading_status.feature @@ -46,7 +46,7 @@ Feature: View the grading status of an assignment And I set the field "Grade out of 100" to "50" And I set the field "Marking workflow state" to "In review" And I set the field "Feedback comments" to "Great job! Lol, not really." - And I set the field "Notify students" to "0" + And I set the field "Notify student" to "0" And I press "Save changes" And I am on the "Test assignment name" "assign activity" page And I follow "View all submissions" @@ -80,7 +80,7 @@ Feature: View the grading status of an assignment And I click on "Grade" "link" in the "Student 1" "table_row" And I should see "1 of 1" And I set the field "Marking workflow state" to "In marking" - And I set the field "Notify students" to "0" + And I set the field "Notify student" to "0" And I press "Save changes" And I am on the "Test assignment name" "assign activity" page And I follow "View all submissions" diff --git a/mod/assign/tests/behat/steps_blind_marking.feature b/mod/assign/tests/behat/steps_blind_marking.feature index 689a3ef8c8d..e46a4c0ca52 100644 --- a/mod/assign/tests/behat/steps_blind_marking.feature +++ b/mod/assign/tests/behat/steps_blind_marking.feature @@ -40,7 +40,7 @@ Feature: Assignments correctly add feedback to the grade report when workflow an And I set the field "Grade out of 100" to "50" And I set the field "Marking workflow state" to "In review" And I set the field "Feedback comments" to "Great job! Lol, not really." - And I set the field "Notify students" to "0" + And I set the field "Notify student" to "0" And I press "Save changes" And I follow "View all submissions" And I should see "In review" in the "I'm the student's first submission" "table_row" @@ -49,7 +49,7 @@ Feature: Assignments correctly add feedback to the grade report when workflow an Scenario: Student identities are revealed after releasing the grades. When I click on "Grade" "link" in the "I'm the student's first submission" "table_row" And I set the field "Marking workflow state" to "Ready for release" - And I set the field "Notify students" to "0" + And I set the field "Notify student" to "0" And I press "Save changes" And I follow "View all submissions" And I should see "Ready for release" in the "I'm the student's first submission" "table_row" @@ -71,7 +71,7 @@ Feature: Assignments correctly add feedback to the grade report when workflow an Scenario: Student identities are revealed before releasing the grades. When I click on "Grade" "link" in the "I'm the student's first submission" "table_row" And I set the field "Marking workflow state" to "Ready for release" - And I set the field "Notify students" to "0" + And I set the field "Notify student" to "0" And I press "Save changes" And I follow "View all submissions" And I should see "Ready for release" in the "I'm the student's first submission" "table_row" diff --git a/mod/feedback/tests/behat/anonymous.feature b/mod/feedback/tests/behat/anonymous.feature index a2ae14902b3..b0cbf891d8c 100644 --- a/mod/feedback/tests/behat/anonymous.feature +++ b/mod/feedback/tests/behat/anonymous.feature @@ -63,7 +63,7 @@ Feature: Anonymous feedback @javascript Scenario: Complete anonymous feedback and view analysis on the front page as an authenticated user And I log in as "admin" - And I set the following system permissions of "Authenticated user on frontpage" role: + And I set the following system permissions of "Authenticated user on site home" role: | capability | permission | | mod/feedback:viewanalysepage | Allow | And I log out diff --git a/mod/feedback/tests/behat/non_anonymous.feature b/mod/feedback/tests/behat/non_anonymous.feature index a8c30b97628..80b1e4401e5 100644 --- a/mod/feedback/tests/behat/non_anonymous.feature +++ b/mod/feedback/tests/behat/non_anonymous.feature @@ -59,7 +59,7 @@ Feature: Non anonymous feedback @javascript Scenario: Complete non anonymous feedback and view analysis on the front page as an authenticated user And I log in as "admin" - And I set the following system permissions of "Authenticated user on frontpage" role: + And I set the following system permissions of "Authenticated user on site home" role: | capability | permission | | mod/feedback:viewanalysepage | Allow | And I log out diff --git a/question/bank/statistics/tests/behat/statistics_values.feature b/question/bank/statistics/tests/behat/statistics_values.feature index ca2fb1f83a0..35ee73a47a2 100644 --- a/question/bank/statistics/tests/behat/statistics_values.feature +++ b/question/bank/statistics/tests/behat/statistics_values.feature @@ -111,12 +111,12 @@ Feature: Show statistics in question bank And I select "Questions" from the "questionbankactionselect" singleselect When I navigate to "Question bank" in current page administration And I select "Questions" from the "questionbankactionselect" singleselect - And I should see "likely" in the "TF1" "table_row" - And I should see "unlikely" in the "TF2" "table_row" - And I should see "unlikely" in the "TF3" "table_row" - And I should see "likely" in the "TF4" "table_row" - And I should see "likely" in the ".alert-warning" "css_element" - And I should see "unlikely" in the ".alert-success" "css_element" + And I should see "Likely" in the "TF1" "table_row" + And I should see "Unlikely" in the "TF2" "table_row" + And I should see "Unlikely" in the "TF3" "table_row" + And I should see "Likely" in the "TF4" "table_row" + And I should see "Likely" in the ".alert-warning" "css_element" + And I should see "Unlikely" in the ".alert-success" "css_element" Scenario: View discrimination index in question bank, bad questions Given user "student1" has attempted "Quiz 2" with responses: @@ -134,9 +134,9 @@ Feature: Show statistics in question bank When I am on the "Course 1" course page logged in as admin When I navigate to "Question bank" in current page administration And I select "Questions" from the "questionbankactionselect" singleselect - And I should see "likely" in the "TF1" "table_row" - And I should see "very likely" in the "TF2" "table_row" - And I should see "very likely" in the "TF3" "table_row" - And I should see "likely" in the "TF4" "table_row" - And I should see "very likely" in the ".alert-danger" "css_element" - And I should see "likely" in the ".alert-warning" "css_element" + And I should see "Likely" in the "TF1" "table_row" + And I should see "Very likely" in the "TF2" "table_row" + And I should see "Very likely" in the "TF3" "table_row" + And I should see "Likely" in the "TF4" "table_row" + And I should see "Very likely" in the ".alert-danger" "css_element" + And I should see "Likely" in the ".alert-warning" "css_element"