moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 17:06:53 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Use DISTINCT instead of GROUP BY in get_site_users

Browse source
This commit is contained in:
moodler 2004-03-09 15:35:07 +00:00
parent 3a954ad47f
commit 4855286e27
1 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
lib/datalib.php
View file

@ -1269,20 +1269,20 @@ function get_site_users($sort="u.lastaccess DESC", $select="") {
"u.email, u.emailstop, u.city, u.country, u.lastaccess, u.lastlogin, u.picture, u.lang, u.timezone"; "u.email, u.emailstop, u.city, u.country, u.lastaccess, u.lastlogin, u.picture, u.lang, u.timezone";
} }
if (!$users = get_records_sql("SELECT $selectinfo from {$CFG->prefix}user u, {$CFG->prefix}user_students s if (!$users = get_records_sql("SELECT DISTINCT $selectinfo from {$CFG->prefix}user u, {$CFG->prefix}user_students s
WHERE s.userid = u.id GROUP BY u.id ORDER BY $sort")) { WHERE s.userid = u.id ORDER BY $sort")) {
$users = array(); $users = array();
} }
if ($teachers = get_records_sql("SELECT $selectinfo from {$CFG->prefix}user u, {$CFG->prefix}user_teachers t if ($teachers = get_records_sql("SELECT DISTINCT $selectinfo from {$CFG->prefix}user u, {$CFG->prefix}user_teachers t
WHERE t.userid = u.id GROUP BY u.id ORDER BY $sort")) { WHERE t.userid = u.id ORDER BY $sort")) {
foreach ($teachers as $teacher) { foreach ($teachers as $teacher) {
$users[$teacher->id] = $teacher; $users[$teacher->id] = $teacher;
} }
} }
if ($admins = get_records_sql("SELECT $selectinfo from {$CFG->prefix}user u, {$CFG->prefix}user_admins a if ($admins = get_records_sql("SELECT DISTINCT $selectinfo from {$CFG->prefix}user u, {$CFG->prefix}user_admins a
WHERE a.userid = u.id GROUP BY u.id ORDER BY $sort")) { WHERE a.userid = u.id ORDER BY $sort")) {
foreach ($admins as $admin) { foreach ($admins as $admin) {
$users[$admin->id] = $admin; $users[$admin->id] = $admin;
} }