moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-04 16:36:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-37781 Check for switching the workshop phase without waiting for cron

Browse source 
Now we are checking for the need to switch the phase when the main
view.php is displayed to any user (previously this was done via cron
only). To give our subplugins (such as the scheduled allocation method)
a chance to do what they need to do, the workshop_viewed event is
triggered before the phase is actually switched.
This commit is contained in:
David Mudrák 2013-01-31 03:25:56 +01:00
parent 913084399a
commit 4ab0bf0f31
2 changed files with 19 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
mod/workshop/version.php
View file

@ -24,7 +24,7 @@
defined('MOODLE_INTERNAL') || die();
$module->version = 2012061700; // the current module version (YYYYMMDDXX)
$module->version = 2012061701; // the current module version (YYYYMMDDXX)
$module->requires = 2012061700; // requires this Moodle version
$module->component = 'mod_workshop'; // full name of the plugin (used for diagnostics)
$module->cron = 60; // give as a chance every minute

18
mod/workshop/view.php
View file

@ -59,6 +59,24 @@ $workshop->log('view');
$completion = new completion_info($course);
$completion->set_module_viewed($cm);
// Fire the event
events_trigger('workshop_viewed', (object)array(
'workshop' => $workshop,
'user' => $USER,
));
// If the phase is to be switched, do it asap. This just has to happen after triggering
// the event so that the scheduled allocator had a chance to allocate submissions.
if ($workshop->phase == workshop::PHASE_SUBMISSION and $workshop->phaseswitchassessment
and $workshop->submissionend > 0 and $workshop->submissionend < time()) {
$workshop->switch_phase(workshop::PHASE_ASSESSMENT);
$workshop->log('update switch phase', $workshop->view_url(), $workshop->phase);
// Disable the automatic switching now so that it is not executed again by accident
// if the teacher changes the phase back to the submission one.
$DB->set_field('workshop', 'phaseswitchassessment', 0, array('id' => $workshop->id));
$workshop->phaseswitchassessment = 0;
}
if (!is_null($editmode) && $PAGE->user_allowed_editing()) {
$USER->editing = $editmode;
}