moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-04 16:36:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-20636 make qe upgrade tests independent of html2text details.

Browse source 
Based on Eloy's change, but refactored to be slightly nicer.
This commit is contained in:
Tim Hunt 2011-06-06 17:05:54 +01:00
parent 0370e3ab0d
commit 4c5743343f
14 changed files with 79 additions and 50 deletions
Download patch file Download diff file Expand all files Collapse all files

29
question/engine/upgrade/simpletest/helper.php
View file

@ -125,4 +125,33 @@ class question_attempt_upgrader_test_base extends UnitTestCase {
public function tearDown() {
$this->updater = null;
}
/**
* Clear text, bringing independence of html2text results
*
* Some tests performing text comparisons of converted text are too much
* dependent of the behavior of the html2text library. This function is
* aimed to reduce such dependencies that should not affect the results
* of these question attempt upgrade tests.
*/
protected function clear_html2text_dependencies($qa) {
// Cleaning all whitespace should be enough to ignore any html2text dependency
if (property_exists($qa, 'responsesummary')) {
$qa->responsesummary = preg_replace('/\s/', '', $qa->responsesummary);
}
if (property_exists($qa, 'questionsummary')) {
$qa->questionsummary = preg_replace('/\s/', '', $qa->questionsummary);
}
}
/**
* Compare two qas, ignoring inessential differences.
* @param object $expectedqa the expected qa.
* @param object $qa the actual qa.
*/
protected function compare_qas($expectedqa, $qa) {
$this->clear_html2text_dependencies($expectedqa);
$this->clear_html2text_dependencies($qa);
$this->assertEqual($expectedqa, $qa);
}
}