moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-08 10:26:40 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge branch 'MDL-52791' of git://github.com/timhunt/moodle

Browse source
This commit is contained in:
Dan Poltawski 2016-01-25 14:26:59 +00:00 • committed by David Monllao
commit 4ce6dac426
1 changed files with 13 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

21
mod/quiz/classes/structure.php
View file

@ -181,7 +181,7 @@ class structure {
return false; return false;
} }
if ($this->get_question_type_for_slot($slotnumber) == 'random') { if (in_array($this->get_question_type_for_slot($slotnumber), array('random', 'missingtype'))) {
return \question_engine::can_questions_finish_during_the_attempt( return \question_engine::can_questions_finish_during_the_attempt(
$this->quizobj->get_quiz()->preferredbehaviour); $this->quizobj->get_quiz()->preferredbehaviour);
} }
@ -190,14 +190,19 @@ class structure {
return $this->slotsinorder[$slotnumber]->canfinish; return $this->slotsinorder[$slotnumber]->canfinish;
} }
$quba = \question_engine::make_questions_usage_by_activity('mod_quiz', $this->quizobj->get_context()); try {
$tempslot = $quba->add_question(\question_bank::load_question( $quba = \question_engine::make_questions_usage_by_activity('mod_quiz', $this->quizobj->get_context());
$this->slotsinorder[$slotnumber]->questionid)); $tempslot = $quba->add_question(\question_bank::load_question(
$quba->set_preferred_behaviour($this->quizobj->get_quiz()->preferredbehaviour); $this->slotsinorder[$slotnumber]->questionid));
$quba->start_all_questions(); $quba->set_preferred_behaviour($this->quizobj->get_quiz()->preferredbehaviour);
$quba->start_all_questions();
$this->slotsinorder[$slotnumber]->canfinish = $quba->can_question_finish_during_attempt($tempslot); $this->slotsinorder[$slotnumber]->canfinish = $quba->can_question_finish_during_attempt($tempslot);
return $this->slotsinorder[$slotnumber]->canfinish; return $this->slotsinorder[$slotnumber]->canfinish;
} catch (\Exception $e) {
// If the question fails to start, this should not block editing.
return false;
}
} }
/** /**