moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 08:56:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-42044 minor add-on installer unit tests cleanup

Browse source
This commit is contained in:
Petr Škoda 2013-10-18 22:39:30 +02:00
parent 99456a5559
commit 4cf944c6bc
2 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

6
admin/tool/installaddon/tests/installer_test.php
View file

@ -42,7 +42,7 @@ class tool_installaddon_installer_testcase extends advanced_testcase {
$this->assertEquals(1, preg_match('~^site=(.+)$~', $query, $matches)); $this->assertEquals(1, preg_match('~^site=(.+)$~', $query, $matches));
$site = rawurldecode($matches[1]); $site = rawurldecode($matches[1]);
$site = json_decode(base64_decode($site), true); $site = json_decode(base64_decode($site), true);
$this->assertEquals('array', gettype($site)); $this->assertInternalType('array', $site);
$this->assertEquals(3, count($site)); $this->assertEquals(3, count($site));
$this->assertSame('Nasty site', $site['fullname']); $this->assertSame('Nasty site', $site['fullname']);
$this->assertSame('file:///etc/passwd', $site['url']); $this->assertSame('file:///etc/passwd', $site['url']);
@ -57,8 +57,8 @@ class tool_installaddon_installer_testcase extends advanced_testcase {
$installer = tool_installaddon_installer::instance(); $installer = tool_installaddon_installer::instance();
$files = $installer->extract_installfromzip_file($sourcedir.'/testinvalidroot.zip', $contentsdir, 'fixed_root'); $files = $installer->extract_installfromzip_file($sourcedir.'/testinvalidroot.zip', $contentsdir, 'fixed_root');
$this->assertEquals('array', gettype($files)); $this->assertInternalType('array', $files);
$this->assertEquals(4, count($files)); $this->assertCount(4, $files);
$this->assertSame(true, $files['fixed_root/']); $this->assertSame(true, $files['fixed_root/']);
$this->assertSame(true, $files['fixed_root/lang/']); $this->assertSame(true, $files['fixed_root/lang/']);
$this->assertSame(true, $files['fixed_root/lang/en/']); $this->assertSame(true, $files['fixed_root/lang/en/']);

10
admin/tool/installaddon/tests/validator_test.php
View file

@ -33,7 +33,7 @@ defined('MOODLE_INTERNAL') || die();
* @copyright 2013 David Mudrak <david@moodle.com> * @copyright 2013 David Mudrak <david@moodle.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/ */
class tool_installaddon_validator_test extends basic_testcase { class tool_installaddon_validator_testcase extends basic_testcase {
public function test_validate_files_layout() { public function test_validate_files_layout() {
$fixtures = dirname(__FILE__).'/fixtures'; $fixtures = dirname(__FILE__).'/fixtures';
@ -159,8 +159,8 @@ class tool_installaddon_validator_test extends basic_testcase {
$this->assertEquals('foobar', $validator->get_rootdir()); $this->assertEquals('foobar', $validator->get_rootdir());
$this->assertTrue($this->has_message($validator->get_messages(), $validator::INFO, 'rootdir', 'foobar')); $this->assertTrue($this->has_message($validator->get_messages(), $validator::INFO, 'rootdir', 'foobar'));
$versionphpinfo = $validator->get_versionphp_info(); $versionphpinfo = $validator->get_versionphp_info();
$this->assertEquals('array', gettype($versionphpinfo)); $this->assertInternalType('array', $versionphpinfo);
$this->assertEquals(4, count($versionphpinfo)); $this->assertCount(4, $versionphpinfo);
$this->assertEquals(2013031900, $versionphpinfo['version']); $this->assertEquals(2013031900, $versionphpinfo['version']);
$this->assertEquals(2013031200, $versionphpinfo['requires']); $this->assertEquals(2013031200, $versionphpinfo['requires']);
$this->assertEquals('local_foobar', $versionphpinfo['component']); $this->assertEquals('local_foobar', $versionphpinfo['component']);
@ -279,8 +279,8 @@ class tool_installaddon_validator_test extends basic_testcase {
$this->assertEquals('testable_tool_installaddon_validator', get_class($validator)); $this->assertEquals('testable_tool_installaddon_validator', get_class($validator));
$info = $validator->testable_parse_version_php($fixtures.'/version1.php'); $info = $validator->testable_parse_version_php($fixtures.'/version1.php');
$this->assertEquals('array', gettype($info)); $this->assertInternalType('array', $info);
$this->assertEquals(7, count($info)); $this->assertCount(7, $info);
$this->assertEquals('block_foobar', $info['plugin->component']); // Later in the file. $this->assertEquals('block_foobar', $info['plugin->component']); // Later in the file.
$this->assertEquals('2013010100', $info['plugin->version']); // Numeric wins over strings. $this->assertEquals('2013010100', $info['plugin->version']); // Numeric wins over strings.
$this->assertEquals('2012122401', $info['plugin->requires']); // Commented. $this->assertEquals('2012122401', $info['plugin->requires']); // Commented.