diff --git a/lib/tests/weblib_test.php b/lib/tests/weblib_test.php index c9586f5c4b6..f7f2fca6462 100644 --- a/lib/tests/weblib_test.php +++ b/lib/tests/weblib_test.php @@ -217,56 +217,46 @@ class web_testcase extends advanced_testcase { $this->resetAfterTest(false); $trace = new null_progress_trace(); - ob_start(); $trace->output('do'); $trace->output('re', 1); $trace->output('mi', 2); $trace->finished(); $output = ob_get_contents(); - ob_end_clean(); $this->assertSame('', $output); + $this->expectOutputString(''); } public function test_text_progres_trace() { $this->resetAfterTest(false); $trace = new text_progress_trace(); - ob_start(); $trace->output('do'); $trace->output('re', 1); $trace->output('mi', 2); $trace->finished(); - $output = ob_get_contents(); - ob_end_clean(); - $this->assertSame("do\n re\n mi\n", $output); + $this->expectOutputString("do\n re\n mi\n"); } public function test_html_progres_trace() { $this->resetAfterTest(false); $trace = new html_progress_trace(); - ob_start(); $trace->output('do'); $trace->output('re', 1); $trace->output('mi', 2); $trace->finished(); - $output = ob_get_contents(); - ob_end_clean(); - $this->assertSame("

do

\n

  re

\n

    mi

\n", $output); + $this->expectOutputString("

do

\n

  re

\n

    mi

\n"); } public function test_html_list_progress_trace() { $this->resetAfterTest(false); $trace = new html_list_progress_trace(); - ob_start(); $trace->output('do'); $trace->output('re', 1); $trace->output('mi', 2); $trace->finished(); - $output = ob_get_contents(); - ob_end_clean(); - $this->assertSame("\n", $output); + $this->expectOutputString("\n"); } public function test_progres_trace_buffer() { @@ -284,18 +274,15 @@ class web_testcase extends advanced_testcase { $this->assertSame($output, $trace->get_buffer()); $trace = new progress_trace_buffer(new html_progress_trace(), false); - ob_start(); $trace->output('do'); $trace->output('re', 1); $trace->output('mi', 2); $trace->finished(); - $output = ob_get_contents(); - ob_end_clean(); - $this->assertSame('', $output); $this->assertSame("

do

\n

  re

\n

    mi

\n", $trace->get_buffer()); $this->assertSame("

do

\n

  re

\n

    mi

\n", $trace->get_buffer()); $trace->reset_buffer(); $this->assertSame('', $trace->get_buffer()); + $this->expectOutputString(''); } public function test_combined_progres_trace() { @@ -305,16 +292,12 @@ class web_testcase extends advanced_testcase { $trace2 = new progress_trace_buffer(new text_progress_trace(), false); $trace = new combined_progress_trace(array($trace1, $trace2)); - - ob_start(); $trace->output('do'); $trace->output('re', 1); $trace->output('mi', 2); $trace->finished(); - $output = ob_get_contents(); - ob_end_clean(); - $this->assertSame('', $output); $this->assertSame("

do

\n

  re

\n

    mi

\n", $trace1->get_buffer()); $this->assertSame("do\n re\n mi\n", $trace2->get_buffer()); + $this->expectOutputString(''); } }