From 52eebcc8df07e00e92ec299392818c06b8d886c6 Mon Sep 17 00:00:00 2001 From: Rossiani Wijaya Date: Wed, 30 Nov 2011 14:00:33 +0800 Subject: [PATCH] MDL-30202 forum rss: move check to the end of if statement to prevent unnecessary db process if rss is disable --- mod/forum/lib.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mod/forum/lib.php b/mod/forum/lib.php index 434655537b5..a26e39443cf 100644 --- a/mod/forum/lib.php +++ b/mod/forum/lib.php @@ -7439,7 +7439,7 @@ function forum_extend_settings_navigation(settings_navigation $settingsnav, navi $hascourseaccess = ($PAGE->course->id == SITEID) || can_access_course($PAGE->course, $userid); $enablerssfeeds = !empty($CFG->enablerssfeeds) && !empty($CFG->forum_enablerssfeeds); - if ($hascourseaccess && $enablerssfeeds && $forumobject->rsstype && $forumobject->rssarticles) { + if ($enablerssfeeds && $forumobject->rsstype && $forumobject->rssarticles && $hascourseaccess) { if (!function_exists('rss_get_url')) { require_once("$CFG->libdir/rsslib.php");