MDL-78885 aria: Fix pressing Home and End on editable comboboxes

This commit is contained in:
Shamim Rezaie 2023-10-12 09:09:43 +11:00
parent e0d2a3924e
commit 535bfb3052
6 changed files with 4 additions and 16 deletions

View file

@ -244,10 +244,6 @@ Feature: Within the grader report, test that we can search for users
And the page should meet accessibility standards with "wcag131, wcag141, wcag412" extra tests And the page should meet accessibility standards with "wcag131, wcag141, wcag412" extra tests
And I press the down key And I press the down key
And ".active" "css_element" should exist in the "Student 1" "option_role" And ".active" "css_element" should exist in the "Student 1" "option_role"
And I press the end key
And ".active" "css_element" should exist in the "View all results (5)" "option_role"
And I press the home key
And ".active" "css_element" should exist in the "Student 1" "option_role"
And I press the up key And I press the up key
And ".active" "css_element" should exist in the "View all results (5)" "option_role" And ".active" "css_element" should exist in the "View all results (5)" "option_role"
And I press the down key And I press the down key

View file

@ -188,10 +188,6 @@ Feature: Within the singleview report, a teacher can search for users.
When I wait until "Turtle Manatee" "option_role" exists When I wait until "Turtle Manatee" "option_role" exists
And I press the down key And I press the down key
And ".active" "css_element" should exist in the "Student 1" "option_role" And ".active" "css_element" should exist in the "Student 1" "option_role"
And I press the end key
And ".active" "css_element" should exist in the "Dummy User" "option_role"
And I press the home key
And ".active" "css_element" should exist in the "Student 1" "option_role"
And I press the up key And I press the up key
And ".active" "css_element" should exist in the "Dummy User" "option_role" And ".active" "css_element" should exist in the "Dummy User" "option_role"
And I press the down key And I press the down key

View file

@ -205,10 +205,6 @@ Feature: Within the User report, a teacher can search for users.
When "Turtle Manatee" "option_role" should exist When "Turtle Manatee" "option_role" should exist
And I press the down key And I press the down key
And ".active" "css_element" should exist in the "Student 1" "option_role" And ".active" "css_element" should exist in the "Student 1" "option_role"
And I press the end key
And ".active" "css_element" should exist in the "View all results (5)" "option_role"
And I press the home key
And ".active" "css_element" should exist in the "Student 1" "option_role"
And I press the up key And I press the up key
And ".active" "css_element" should exist in the "View all results (5)" "option_role" And ".active" "css_element" should exist in the "View all results (5)" "option_role"
And I press the down key And I press the down key

File diff suppressed because one or more lines are too long

File diff suppressed because one or more lines are too long

View file

@ -313,9 +313,9 @@ const comboboxFix = () => {
if (editable && !next) { if (editable && !next) {
next = options[options.length - 1]; next = options[options.length - 1];
} }
} else if (trigger == 'Home') { } else if (trigger == 'Home' && !editable) {
next = options[0]; next = options[0];
} else if (trigger == 'End') { } else if (trigger == 'End' && !editable) {
next = options[options.length - 1]; next = options[options.length - 1];
} else if ((trigger == ' ' && !editable) || trigger == 'Enter') { } else if ((trigger == ' ' && !editable) || trigger == 'Enter') {
e.preventDefault(); e.preventDefault();