moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 00:46:50 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

accesslib: get_user_courses_bycap() is less of a piggy now...

Browse source 
get_user_courses_bycap() replaces get_courses_bycap_fromsess().

Using a combination of in-DB enrolments and in-session capability
checks, we narrow down the courses we fetch from the DB for checking.

This patch adds a small DB query, and has has a moderate impact on
the timings observable on my laptop (~300ms?), but reduces
*significantly* the bandwidth used, which in cluster environments
with frontends separate from backends has a serious impact.
This commit is contained in:
martinlanghoff 2007-09-19 07:04:23 +00:00
parent aeb3916b7a
commit 573674bf47
2 changed files with 94 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

10
lib/datalib.php
View file

@ -585,7 +585,7 @@ function get_courses_page($categoryid="all", $sort="c.sortorder ASC", $fields="c
* List of courses that a user has access to view. Note that for admins,
* this usually includes every course on the system.
*
* Notes (inherited from get_courses_bycap_fromsess()):
* Notes (inherited from get_user_courses_bycap()):
*
* - $fields is an array of fieldnames to ADD
* so name the fields you really need, which will
@ -617,7 +617,7 @@ function get_my_courses($userid, $sort='visible DESC,sortorder ASC', $fields=NUL
$fields = NULL;
} else {
// turn the fields from a string to an array that
// get_courses_bycap_fromsess() will like...
// get_user_courses_bycap() will like...
$fields = explode(',',$fields);
$fields = array_map('trim', $fields);
}
@ -628,9 +628,9 @@ function get_my_courses($userid, $sort='visible DESC,sortorder ASC', $fields=NUL
} else {
$accessinfo = get_user_access_sitewide($userid);
}
$courses = get_courses_bycap_fromsess('moodle/course:view', $accessinfo,
$doanything, $sort, $fields,
$limit);
$courses = get_user_courses_bycap($userid, 'moodle/course:view', $accessinfo,
$doanything, $sort, $fields,
$limit);
// strangely, get_my_courses() is expected to return the
// array keyed on id, which messes up the sorting
$kcourses = array();