moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-07 18:06:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-71011 php80: final private makes no sense, throwing warning

Browse source 
Ref: https://php.watch/versions/8.0/final-private-function#final-private

This applies #712 from upstream libraries.

Unrelated: I've also changed a occurrence of "private final"
by the correct (PSR-12) "final private" in the constructor
(the final&private combination is allowed in constructors)
in lib/classes/event/base.php, because it's the unique case
in core and phpcs was really insisting.
This commit is contained in:
Eloy Lafuente (stronk7) 2021-03-27 18:16:07 +01:00
parent 91969d1e04
commit 59a8b7182b
5 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/classes/event/base.php
View file

@ -134,7 +134,7 @@ abstract class base implements \IteratorAggregate {
/**
* Private constructor, use create() or restore() methods instead.
*/
private final function __construct() {
final private function __construct() {
$this->data = array_fill_keys(self::$fields, null);
// Define some basic details.