From 8732ddd5d3329fedfe20eb4d776933403716e436 Mon Sep 17 00:00:00 2001 From: Amaia Anabitarte Date: Wed, 7 Apr 2021 17:07:22 +0200 Subject: [PATCH] MDL-71274 analytics: Don't generate insight for hidden courses Hidden courses can be used for training but we do not want to generate insights for them because students do not have access to hidden courses. This was fixed in MDL-66806 for "Students at risk" model. Fixed for "Students who have not accessed the course recently" in this issue. --- course/classes/analytics/target/no_recent_accesses.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/course/classes/analytics/target/no_recent_accesses.php b/course/classes/analytics/target/no_recent_accesses.php index 836e1f84735..5244d5ade16 100644 --- a/course/classes/analytics/target/no_recent_accesses.php +++ b/course/classes/analytics/target/no_recent_accesses.php @@ -103,6 +103,10 @@ class no_recent_accesses extends course_enrolments { return get_string('nocoursestudents', 'course'); } + if (!$fortraining && !$course->get_course_data()->visible) { + return get_string('hiddenfromstudents'); + } + if ($course->get_end() && $course->get_end() < $course->get_start()) { return get_string('errorendbeforestart', 'course'); }