moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 08:56:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

updated report to find the times in timer table, now much more accurate. Also fixed a sesskey problem

Browse source
This commit is contained in:
michaelpenne 2005-02-25 19:12:39 +00:00
parent ff2978cea0
commit 5f3b3a084a
1 changed files with 64 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

85
mod/lesson/report.php
View file

@ -41,6 +41,10 @@
$grades = array(); $grades = array();
} }
if (! $times = get_records('lesson_timer', 'lessonid', $lesson->id, 'starttime')) {
$times = array();
}
// make sure people are where they should be // make sure people are where they should be
require_login($course->id, false); require_login($course->id, false);
@ -56,6 +60,7 @@
} }
$button = '<form target="'. $CFG->framename .'" method="get" action="'. $CFG->wwwroot .'/course/mod.php">'. $button = '<form target="'. $CFG->framename .'" method="get" action="'. $CFG->wwwroot .'/course/mod.php">'.
'<input type="hidden" name="update" value="'. $cm->id .'" />'. '<input type="hidden" name="update" value="'. $cm->id .'" />'.
'<input type="hidden" name="sesskey" value="'. $USER->sesskey .'" />'.
'<input type="hidden" name="return" value="true" />'. '<input type="hidden" name="return" value="true" />'.
'<input type="submit" value="'. get_string('editlessonsettings', 'lesson') .'" /></form>'; '<input type="submit" value="'. get_string('editlessonsettings', 'lesson') .'" /></form>';
@ -85,7 +90,8 @@
if (!array_key_exists($attempt->userid, $studentdata) || !array_key_exists($attempt->retry, $studentdata[$attempt->userid])) { if (!array_key_exists($attempt->userid, $studentdata) || !array_key_exists($attempt->retry, $studentdata[$attempt->userid])) {
// restore/setup defaults // restore/setup defaults
$n = 0; $n = 0;
$timeend = NULL; $timestart = 0;
$timeend = 0;
$usergrade = NULL; $usergrade = NULL;
// search for the grade record for this try. if not there, the nulls defined above will be used. // search for the grade record for this try. if not there, the nulls defined above will be used.
@ -95,31 +101,46 @@
// see if n is = to the retry // see if n is = to the retry
if ($n == $attempt->retry) { if ($n == $attempt->retry) {
// get grade info // get grade info
$timeend = $grade->completed;
$usergrade = $grade->grade; $usergrade = $grade->grade;
break; break;
} }
$n++; // if not equal, then increment n $n++; // if not equal, then increment n
} }
} }
$n = 0;
// search for the time record for this try. if not there, the nulls defined above will be used.
foreach($times as $time) {
// check to see if the grade matches the correct user
if ($time->userid == $attempt->userid) {
// see if n is = to the retry
if ($n == $attempt->retry) {
// get grade info
$timeend = $time->lessontime;
$timestart = $time->starttime;
break;
}
$n++; // if not equal, then increment n
}
}
// build up the array. // build up the array.
// this array represents each student and all of their tries at the lesson // this array represents each student and all of their tries at the lesson
$studentdata[$attempt->userid][$attempt->retry] = array( "timestart" => $attempt->timeseen, $studentdata[$attempt->userid][$attempt->retry] = array( "timestart" => $timestart,
"timeend" => $timeend, "timeend" => $timeend,
"grade" => $usergrade, "grade" => $usergrade,
"try" => $attempt->retry, "try" => $attempt->retry,
"userid" => $attempt->userid); "userid" => $attempt->userid);
} }
} }
// set all the stats variables to 0 // set all the stats variables
$numofattempts = 0; $numofattempts = 0;
$avescore = 0; $avescore = 0;
$avetime = 0; $avetime = 0;
$highscore = 0; $highscore = NULL;
$lowscore = 1000000000000; // silly, but should work $lowscore = NULL;
$hightime = 0; $hightime = NULL;
$lowtime = 1000000000000; // :) $lowtime = NULL;
$table = new stdClass; $table = new stdClass;
// set up the table object // set up the table object
$table->head = array(get_string('studentname', 'lesson', $course->student), get_string('attempts', 'lesson'), get_string('highscore', 'lesson')); $table->head = array(get_string('studentname', 'lesson', $course->student), get_string('attempts', 'lesson'), get_string('highscore', 'lesson'));
@ -150,7 +171,7 @@
// userid to the userid which was clicked, and sets hidden form variables try, timetotake, completed, and grade // userid to the userid which was clicked, and sets hidden form variables try, timetotake, completed, and grade
$temp = "<a href=\"javascript: document.forms['overview'].elements['userid'].value = '".$try["userid"]."'; ". $temp = "<a href=\"javascript: document.forms['overview'].elements['userid'].value = '".$try["userid"]."'; ".
"document.forms['overview'].elements['try'].value = '".$try["try"]."'; "; "document.forms['overview'].elements['try'].value = '".$try["try"]."'; ";
if ($try["grade"] != NULL && $try["timeend"] != NULL) { // basically, both will be set, or both will be null. Both are based on same thing if ($try["grade"] != NULL) { // if NULL then not done yet
// this is what the link does when the user has completed the try // this is what the link does when the user has completed the try
$timetotake = $try["timeend"] - $try["timestart"]; $timetotake = $try["timeend"] - $try["timestart"];
@ -185,16 +206,16 @@
$numofattempts++; $numofattempts++;
$avescore += $try["grade"]; $avescore += $try["grade"];
$avetime += $timetotake; $avetime += $timetotake;
if ($try["grade"] > $highscore) { if ($try["grade"] > $highscore || $highscore == NULL) {
$highscore = $try["grade"]; $highscore = $try["grade"];
} }
if ($try["grade"] < $lowscore) { if ($try["grade"] < $lowscore || $lowscore == NULL) {
$lowscore = $try["grade"]; $lowscore = $try["grade"];
} }
if ($timetotake > $hightime) { if ($timetotake > $hightime || $hightime == NULL) {
$hightime = $timetotake; $hightime = $timetotake;
} }
if ($timetotake < $lowtime) { if ($timetotake < $lowtime || $lowtime == NULL) {
$lowtime = $timetotake; $lowtime = $timetotake;
} }
} }
@ -217,11 +238,33 @@
echo "</form>"; echo "</form>";
// some stat calculations // some stat calculations
$avescore = format_float($avescore/$numofattempts, 2, ".", ","); if ($numofattempts == 0) {
$avetime = format_float($avetime/$numofattempts, 0, ".", ","); $avescore = get_string("notcompleted", "lesson");
$avetime = format_time($avetime); } else {
$hightime = format_time($hightime); $avescore = format_float($avescore/$numofattempts, 2, ".", ",");
$lowtime = format_time($lowtime); }
if ($avetime == NULL) {
$avetime = get_string("notcompleted", "lesson");
} else {
$avetime = format_float($avetime/$numofattempts, 0, ".", ",");
$avetime = format_time($avetime);
}
if ($hightime == NULL) {
$hightime = get_string("notcompleted", "lesson");
} else {
$hightime = format_time($hightime);
}
if ($lowtime == NULL) {
$lowtime = get_string("notcompleted", "lesson");
} else {
$lowtime = format_time($lowtime);
}
if ($highscore == NULL) {
$highscore = get_string("notcompleted", "lesson");
}
if ($lowscore == NULL) {
$lowscore = get_string("notcompleted", "lesson");
}
// output the stats // output the stats
print_heading(get_string('lessonstats', 'lesson')); print_heading(get_string('lessonstats', 'lesson'));