diff --git a/cache/classes/helper.php b/cache/classes/helper.php index d63405b6cdb..20e2f6d51ba 100644 --- a/cache/classes/helper.php +++ b/cache/classes/helper.php @@ -511,7 +511,6 @@ class cache_helper { * Update the site identifier stored by the cache API. * * @param string $siteidentifier - * @return string The new site identifier. */ public static function update_site_identifier($siteidentifier) { global $CFG; @@ -520,10 +519,9 @@ class cache_helper { $factory = cache_factory::instance(); $factory->updating_started(); $config = $factory->create_config_instance(true); - $siteidentifier = $config->update_site_identifier($siteidentifier); + $config->update_site_identifier($siteidentifier); $factory->updating_finished(); cache_factory::reset(); - return $siteidentifier; } /** @@ -532,30 +530,11 @@ class cache_helper { * @return string */ public static function get_site_identifier() { - global $CFG; - if (!is_null(self::$siteidentifier)) { - return self::$siteidentifier; - } - // If site identifier hasn't been collected yet attempt to get it from the cache config. - $factory = cache_factory::instance(); - // If the factory is initialising then we don't want to try to get it from the config or we risk - // causing the cache to enter an infinite initialisation loop. - if (!$factory->is_initialising()) { + if (is_null(self::$siteidentifier)) { + $factory = cache_factory::instance(); $config = $factory->create_config_instance(); self::$siteidentifier = $config->get_site_identifier(); } - if (is_null(self::$siteidentifier)) { - // If the site identifier is still null then config isn't aware of it yet. - // We'll see if the CFG is loaded, and if not we will just use unknown. - // It's very important here that we don't use get_config. We don't want an endless cache loop! - if (isset($CFG->siteidentifier)) { - self::$siteidentifier = self::update_site_identifier($CFG->siteidentifier); - } else { - // It's not being recorded in MUC's config and the config data hasn't been loaded yet. - // Likely we are initialising. - return 'unknown'; - } - } return self::$siteidentifier; } diff --git a/cache/locallib.php b/cache/locallib.php index e2b498e19ab..4d6d745dfbc 100644 --- a/cache/locallib.php +++ b/cache/locallib.php @@ -529,12 +529,10 @@ class cache_config_writer extends cache_config { * Update the site identifier stored by the cache API. * * @param string $siteidentifier - * @return string The new site identifier. */ public function update_site_identifier($siteidentifier) { $this->siteidentifier = md5((string)$siteidentifier); $this->config_save(); - return $this->siteidentifier; } }