moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-07 18:06:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-51131 tags: remove instances when course is deleted

Browse source
This commit is contained in:
Marina Glancy 2015-08-22 21:45:06 +08:00
parent ef176837dc
commit 66c0fccb9e
2 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
tag/coursetagslib.php
View file

@ -315,14 +315,16 @@ function coursetag_get_tagged_courses($tagid) {
function coursetag_delete_course_tags($courseid, $showfeedback=false) { function coursetag_delete_course_tags($courseid, $showfeedback=false) {
global $DB, $OUTPUT; global $DB, $OUTPUT;
if ($taginstances = $DB->get_fieldset_select('tag_instance', 'tagid', "itemtype = 'course' AND itemid = :courseid", if ($taginstances = $DB->get_recordset_select('tag_instance', "itemtype = 'course' AND itemid = :courseid",
array('courseid' => $courseid))) { array('courseid' => $courseid), '', 'tagid, tiuserid')) {
tag_delete(array_values($taginstances)); foreach ($taginstances as $record) {
tag_delete_instance('course', $courseid, $record->tagid, $record->tiuserid);
}
$taginstances->close();
} }
if ($showfeedback) { if ($showfeedback) {
echo $OUTPUT->notification(get_string('deletedcoursetags', 'tag'), 'notifysuccess'); echo $OUTPUT->notification(get_string('deletedcoursetags', 'tag'), 'notifysuccess');
} }
} }

2
tag/tests/events_test.php
View file

@ -452,7 +452,7 @@ class core_tag_events_testcase extends advanced_testcase {
$sink = $this->redirectEvents(); $sink = $this->redirectEvents();
coursetag_delete_course_tags($course->id); coursetag_delete_course_tags($course->id);
$events = $sink->get_events(); $events = $sink->get_events();
$events = array($events[2], $events[3]); $events = array($events[1], $events[3]);
// Check that the tags were deleted and the events data is valid. // Check that the tags were deleted and the events data is valid.
$this->assertEquals(0, $DB->count_records('tag')); $this->assertEquals(0, $DB->count_records('tag'));