moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-04 16:36:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-9376, disallow student to see the other users posts in max editing time, credits to Vlas Voloshin and Charles Fulton

Browse source
This commit is contained in:
Dongsheng Cai 2011-03-11 11:22:13 +08:00
parent c09604234a
commit 67fc4f0025
2 changed files with 28 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
mod/forum/lang/en/forum.php
View file

@ -146,7 +146,7 @@ $string['forum'] = 'Forum';
$string['forum:addnews'] = 'Add news'; $string['forum:addnews'] = 'Add news';
$string['forumauthorhidden'] = 'Author (hidden)'; $string['forumauthorhidden'] = 'Author (hidden)';
$string['forumblockingalmosttoomanyposts'] = 'You are approaching the posting threshold. You have posted {$a->numposts} times in the last {$a->blockperiod} and the limit is {$a->blockafter} posts.'; $string['forumblockingalmosttoomanyposts'] = 'You are approaching the posting threshold. You have posted {$a->numposts} times in the last {$a->blockperiod} and the limit is {$a->blockafter} posts.';
$string['forumbodyhidden'] = 'This post cannot be viewed by you, probably because you have not posted in the discussion yet.'; $string['forumbodyhidden'] = 'This post cannot be viewed by you, probably because you have not posted in the discussion or the maximum editing time hasn\'t passed yet.';
$string['forum:createattachment'] = 'Create attachments'; $string['forum:createattachment'] = 'Create attachments';
$string['forum:deleteanypost'] = 'Delete any posts (anytime)'; $string['forum:deleteanypost'] = 'Delete any posts (anytime)';
$string['forum:deleteownpost'] = 'Delete own posts (within deadline)'; $string['forum:deleteownpost'] = 'Delete own posts (within deadline)';

31
mod/forum/lib.php
View file

@ -526,6 +526,11 @@ function forum_cron() {
// oops - this user should not receive anything from this course // oops - this user should not receive anything from this course
continue; continue;
} }
// Don't send email if the forum is Q&A and the user has not posted
if ($forum->type == 'qanda' && !forum_get_user_posted_time($discussion->id, $userto->id)) {
mtrace('Did not email '.$userto->id.' because user has not posted in discussion');
continue;
}
// Get info about the sending user // Get info about the sending user
if (array_key_exists($post->userid, $users)) { // we might know him/her already if (array_key_exists($post->userid, $users)) { // we might know him/her already
@ -4640,8 +4645,25 @@ function forum_user_has_posted($forumid, $did, $userid) {
WHERE p.userid = :userid AND d.forum = :forumid"; WHERE p.userid = :userid AND d.forum = :forumid";
return $DB->record_exists_sql($sql, array('forumid'=>$forumid,'userid'=>$userid)); return $DB->record_exists_sql($sql, array('forumid'=>$forumid,'userid'=>$userid));
} else { } else {
return $DB->record_exists('forum_posts', array('discussion'=>$did,'userid'=>$userid)); return $DB->record_exists('forum_posts', array('discussion'=>$did,'userid'=>$userid));
}
} }
/**
* Returns creation time of the first user's post in given discussion
* @global object $DB
* @param int $did Discussion id
* @param int $userid User id
* @return int|bool post creation time stamp or return false
*/
function forum_get_user_posted_time($did, $userid) {
global $DB;
$posttime = $DB->get_field('forum_posts', 'MIN(created)', array('userid'=>$userid, 'discussion'=>$did));
if (empty($posttime)) {
return false;
}
return $posttime;
} }
/** /**
@ -4893,7 +4915,7 @@ function forum_user_can_see_discussion($forum, $discussion, $context, $user=NULL
* @return bool * @return bool
*/ */
function forum_user_can_see_post($forum, $discussion, $post, $user=NULL, $cm=NULL) { function forum_user_can_see_post($forum, $discussion, $post, $user=NULL, $cm=NULL) {
global $USER, $DB; global $CFG, $USER, $DB;
// retrieve objects (yuk) // retrieve objects (yuk)
if (is_numeric($forum)) { if (is_numeric($forum)) {
@ -4954,9 +4976,10 @@ function forum_user_can_see_post($forum, $discussion, $post, $user=NULL, $cm=NUL
if ($forum->type == 'qanda') { if ($forum->type == 'qanda') {
$firstpost = forum_get_firstpost_from_discussion($discussion->id); $firstpost = forum_get_firstpost_from_discussion($discussion->id);
$modcontext = get_context_instance(CONTEXT_MODULE, $cm->id); $modcontext = get_context_instance(CONTEXT_MODULE, $cm->id);
$userfirstpost = forum_get_user_posted_time($discussion->id, $user->id);
return (forum_user_has_posted($forum->id,$discussion->id,$user->id) || return (($userfirstpost !== false && (time() - $userfirstpost >= $CFG->maxeditingtime)) ||
$firstpost->id == $post->id || $firstpost->id == $post->id || $post->userid == $user->id || $firstpost->userid == $user->id ||
has_capability('mod/forum:viewqandawithoutposting', $modcontext, $user->id, false)); has_capability('mod/forum:viewqandawithoutposting', $modcontext, $user->id, false));
} }
return true; return true;