moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-04 16:36:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-9076 - Move the 'Add 3 more overall feedbacks' button inside that group of elements on the quiz settings form.

Browse source 
To make this possible, I added an extra argument to the repeat_elements method, which other people may find helpful on other forms.
This commit is contained in:
tjhunt 2007-10-09 15:44:06 +00:00
parent e2833e8700
commit 6f3b54c8aa
3 changed files with 9 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

1
lang/en_utf8/quiz.php
View file

@ -22,6 +22,7 @@ $string['addingrandom'] = 'Adding a Random Question';
$string['addingrandomsamatch'] = 'Adding a Random Short-Answer Matching question';
$string['addingshortanswer'] = 'Adding a Short-Answer question';
$string['addingtruefalse'] = 'Adding a True/False question';
$string['addmoreoverallfeedbacks'] = 'Add {no} more feedback fields';
$string['addquestions'] = 'Add questions';
$string['addquestionstoquiz'] = 'Add questions to current quiz';
$string['addrandom'] = 'Add $a random questions';

8
lib/formslib.php
View file

@ -524,9 +524,11 @@ class moodleform {
* @param string $addfieldsname name for button to add more fields
* @param int $addfieldsno how many fields to add at a time
* @param string $addstring name of button, {no} is replaced by no of blanks that will be added.
* @param boolean $addbuttoninside if true, don't call closeHeaderBefore($addfieldsname). Default false.
* @return int no of repeats of element in this page
*/
function repeat_elements($elementobjs, $repeats, $options, $repeathiddenname, $addfieldsname, $addfieldsno=5, $addstring=null){
function repeat_elements($elementobjs, $repeats, $options, $repeathiddenname,
$addfieldsname, $addfieldsno=5, $addstring=null, $addbuttoninside=false){
if ($addstring===null){
$addstring = get_string('addfields', 'form', $addfieldsno);
} else {
@ -598,7 +600,9 @@ class moodleform {
}
$mform->addElement('submit', $addfieldsname, $addstring);
$mform->closeHeaderBefore($addfieldsname);
if (!$addbuttoninside) {
$mform->closeHeaderBefore($addfieldsname);
}
return $repeats;
}

3
mod/quiz/mod_form.php
View file

@ -237,7 +237,8 @@ class mod_quiz_mod_form extends moodleform_mod {
$mform->setType('feedbackboundaries', PARAM_NOTAGS);
$nextel=$this->repeat_elements($repeatarray, $numfeedbacks-1,
array(), 'boundary_repeats', 'boundary_add_fields', 3);
array(), 'boundary_repeats', 'boundary_add_fields', 3,
get_string('addmoreoverallfeedbacks', 'quiz'), true);
//put some extra elements in before the button
$insertEl = &MoodleQuickForm::createElement('text', "feedbacktext[$nextel]", get_string('feedback', 'quiz'), array('size' => 50));