moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-04 08:26:37 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-11113 completely reimplemented editor plugin settings - we should never use custom forms instead of admin settings if possible

Browse source
This commit is contained in:
Petr Skoda 2010-07-04 20:53:01 +00:00
parent 09ae4cad1a
commit 6fc67fce72
4 changed files with 34 additions and 63 deletions
Download patch file Download diff file Expand all files Collapse all files

40
admin/editors.php
View file

@ -17,7 +17,6 @@ $action = optional_param('action', '', PARAM_ACTION);
$editor = optional_param('editor', '', PARAM_SAFEDIR);
// get currently installed and enabled auth plugins
$settingsurl = "$CFG->wwwroot/$CFG->admin/editors.php?sesskey=".sesskey()."&action=edit&editor=$editor";
$available_editors = get_available_editors();
if (!empty($editor) and empty($available_editors[$editor])) {
redirect ($returnurl);
@ -79,45 +78,6 @@ switch ($action) {
}
}
break;
case 'edit':
$form_file = $CFG->dirroot . '/lib/editor/'.$editor.'/settings.php';
if (file_exists($form_file)) {
require_once($form_file);
$classname = 'editor_settings_' . $editor;
$pagename = 'editorsettings' . $editor;
admin_externalpage_setup($pagename);
$form = new $classname();
$options = call_user_func($classname . '::option_names');
$data = $form->get_data();
if ($form->is_cancelled()){
// do nothing
} else if (!empty($data)) {
foreach ($data as $key=>$value) {
// editor options must be started with 'editor_'
if (strpos($key, 'editor_') === 0 && in_array($key, $options)) {
set_config($key, $value, 'editor');
}
}
} else {
$data = array();
foreach ($options as $key) {
$data[$key] = get_config('editor', $key);
}
$form->set_data($data);
$PAGE->set_pagetype('admin-editors-' . $editor);
echo $OUTPUT->header();
echo $OUTPUT->heading(get_string('pluginname', 'editor_'.$editor));
$OUTPUT->box_start();
$form->display();
$OUTPUT->box_end();
echo $OUTPUT->footer();
$return = false;
}
}
break;
default:
break;
}

10
admin/settings/plugins.php
View file

@ -136,13 +136,17 @@ if ($hassiteconfig) {
$ADMIN->add('editorsettings', $temp);
$editors_available = get_available_editors();
$url = $CFG->wwwroot.'/'.$CFG->admin.'/editors.php?sesskey='.sesskey();
foreach ($editors_available as $editor=>$editorstr) {
if (file_exists($CFG->dirroot . '/lib/editor/'.$editor.'/settings.php')) {
$editor_setting = new admin_externalpage('editorsettings'.$editor, $editorstr, $url.'&action=edit&editor='.$editor);
$ADMIN->add('editorsettings', $editor_setting);
$settings = new admin_settingpage('editorsettings'.$editor, get_string('pluginname', 'editor_'.$editor), 'moodle/site:config');
// settings.php may create a subcategory or unset the settings completely
include($CFG->dirroot . '/lib/editor/'.$editor.'/settings.php');
if ($settings) {
$ADMIN->add('editorsettings', $settings);
}
}
}
/// License types
$ADMIN->add('modules', new admin_category('licensesettings', get_string('license')));
$temp = new admin_settingpage('managelicenses', get_string('license'));