moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-05 08:56:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-45605 Phpunit: Do not call gc_collect_cycles as part of reset.

Browse source 
This takes 25% of the time in running tests and there is no benefit. The
behaviour of destructors is the same before/after the patch.
This commit is contained in:
Damyon Wiese 2014-05-19 10:10:59 +08:00
parent a929fd50f9
commit 726b011050
1 changed files with 0 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
lib/phpunit/classes/util.php
View file

@ -112,9 +112,6 @@ class phpunit_util extends testing_util {
// Stop any message redirection. // Stop any message redirection.
phpunit_util::stop_event_redirection(); phpunit_util::stop_event_redirection();
// Release memory and indirectly call destroy() methods to release resource handles, etc.
gc_collect_cycles();
// Show any unhandled debugging messages, the runbare() could already reset it. // Show any unhandled debugging messages, the runbare() could already reset it.
self::display_debugging_messages(); self::display_debugging_messages();
self::reset_debugging(); self::reset_debugging();