moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-07 09:56:38 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-50260 lib: remove unnecessary isset check in optional_param().

Browse source 
There is no need to do check:
if (!isset($default))
As we're guaranteed that function was called with 3 arguments (func_num_args() == 3).
This commit is contained in:
Tomasz Muras 2015-05-21 18:54:28 +02:00
parent 803f565753
commit 75aefe070b
1 changed files with 0 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
lib/moodlelib.php
View file

@ -623,9 +623,6 @@ function optional_param($parname, $default, $type) {
if (func_num_args() != 3 or empty($parname) or empty($type)) {
throw new coding_exception('optional_param requires $parname, $default + $type to be specified (parameter: '.$parname.')');
}
if (!isset($default)) {
$default = null;
}
// POST has precedence.
if (isset($_POST[$parname])) {