moodle/moodle
3
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-06 01:16:44 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MDL-26969 Assignment module - upload: fixed get_submission() return value to nothing when param is set to false.

Browse source
This commit is contained in:
Rossiani Wijaya 2012-07-23 11:19:30 +08:00
parent 3294034b80
commit 75cf84ac25
2 changed files with 12 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
mod/assignment/lib.php
View file

@ -1820,10 +1820,10 @@ class assignment_base {
*
* @global object
* @global object
* @param $userid int The id of the user whose submission we want or 0 in which case USER->id is used
* @param $createnew boolean optional Defaults to false. If set to true a new submission object will be created in the database
* @param int $userid int The id of the user whose submission we want or 0 in which case USER->id is used
* @param bool $createnew boolean optional Defaults to false. If set to true a new submission object will be created in the database
* @param bool $teachermodified student submission set if false
* @return object The submission
* @return object|bool The submission or false if $createnew is false.
*/
function get_submission($userid=0, $createnew=false, $teachermodified=false) {
global $USER, $DB;
@ -1834,8 +1834,10 @@ class assignment_base {
$submission = $DB->get_record('assignment_submissions', array('assignment'=>$this->assignment->id, 'userid'=>$userid));
if ($submission || !$createnew) {
if ($submission) {
return $submission;
} else if(!$createnew) {
return false;
}
$newsubmission = $this->prepare_new_submission($userid, $teachermodified);
$DB->insert_record("assignment_submissions", $newsubmission);